Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe services should carry all information in JSON body #2194

Closed
azaroth42 opened this issue Jan 24, 2023 · 1 comment
Closed

Probe services should carry all information in JSON body #2194

azaroth42 opened this issue Jan 24, 2023 · 1 comment
Labels

Comments

@azaroth42
Copy link
Member

We are currently mixing layers between HTTP and the response payload. The client needs access to the status code (200 vs 4xx (vs 3xx?)) but also information from the body. We should limit to only one layer and just put everything in the JSON body. While this might not be appreciated by purists, it is much easier for implementers and they are our primary audience.

eg.

{
 "id": ...
 "type": "AuthProbeService2",
  "status": "success",
  "for": {...}
}
@azaroth42 azaroth42 added the auth label Jan 24, 2023
@ktamaral
Copy link

The latest version of the IIIF Authorization Flow 2.0 probe service has a property called status that has the value of the status that the service returned. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants