Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image API 2.1 has wrong physdim @context URI in example #935

Closed
1 of 2 tasks
zimeon opened this issue Sep 26, 2016 · 4 comments
Closed
1 of 2 tasks

Image API 2.1 has wrong physdim @context URI in example #935

zimeon opened this issue Sep 26, 2016 · 4 comments
Assignees
@zimeon
Labels
editorial Ready-for-Eds Editorial changes ready for Editorial review
Milestone
Image 2.1.1

Comments

@zimeon
Copy link
Member

zimeon commented Sep 26, 2016 •
edited by jpstroop

We have in http://iiif.io/api/image/2.1/#complete-response :

...
 "service" : [
    {
      "@context": "http://iiif.io/api/annex/service/physdim/1/context.json",
...

whereas in http://iiif.io/api/annex/services/#physical-dimensions it is correct as:

{
  "service": {
    "@context": "http://iiif.io/api/annex/services/physdim/1/context.json",
...

ie. must be /services/ and not /service/.

  • fixed on 2.1.1 branch
  • merged to master
@zimeon
Copy link
Member Author

zimeon commented Sep 26, 2016

& same applies to profile

@azaroth42
Copy link
Member

Ooops :( Image 2.1.1 ?

@jpstroop
Copy link
Member

Agree, 2.1.1. There are a few of these, right?

@zimeon
Copy link
Member Author

zimeon commented Sep 27, 2016

I was at first thinking we just log the change, but I agree it makes sense to use our patch numbering. As far as I can see there are only two cases. (I just checked every use of @context in the doc.)

@zimeon zimeon mentioned this issue Sep 27, 2016
Merged
@zimeon zimeon self-assigned this Sep 27, 2016
@zimeon zimeon added this to the Image 2.1.1 milestone Nov 2, 2016
@azaroth42 azaroth42 added the Ready-for-Eds Editorial changes ready for Editorial review label Mar 29, 2017
@zimeon zimeon changed the title Image API 2.1 has wrong phydim @context URI in example Image API 2.1 has wrong physdim @context URI in example Apr 12, 2017
@jpstroop jpstroop closed this as completed Jun 9, 2017
@jpstroop jpstroop removed the image label Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zimeon zimeon

Labels
editorial Ready-for-Eds Editorial changes ready for Editorial review
Projects
None yet
Milestone
Image 2.1.1
Development

No branches or pull requests
3 participants
@zimeon @azaroth42 @jpstroop