Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pogo-s2 plugin isn't working with IITC-Button on Chrome #5

Closed
fortepc opened this issue May 4, 2019 · 6 comments
Closed

pogo-s2 plugin isn't working with IITC-Button on Chrome #5

fortepc opened this issue May 4, 2019 · 6 comments

Comments

@fortepc
Copy link

fortepc commented May 4, 2019

This plugin works just fine with IITC-CE inside of tampermonkey, but doesn't appear to even try to load when it's inside of IITC-Button.

The plugin is here: https://gitlab.com/AlfonsoML/pogo-s2

The plugin has a few Pokemon Go centric features, such as flagging a portal as a Gym or Pokestop, being able to overlay S2 cells of adjustable sizes, and highlight S2 Cells that are full and cannot accept any new submissions.

Reporting issue on both repos because I'm not sure where the issue actually is.
Issue on their repo: https://gitlab.com/AlfonsoML/pogo-s2/issues/40

@johnd0e
Copy link

johnd0e commented May 4, 2019

IITC-Button could provide unsafeWindow object.
But I am not sure yet that it should..

Maybe better provide GM_Info

@modos189
Copy link
Contributor

modos189 commented May 4, 2019

It is Chrome-specific problem? I've already fixed order of plugins loading and Firefox already has a new version of add-on. In Chrome, the update is in review stage and will be available for updating in a couple of days.

I install https://gitlab.com/AlfonsoML/pogo-s2/raw/master/s2check.user.js in Firefox with IITC-Button and it looks like it's working.

Screenshot

изображение

@johnd0e
Copy link

johnd0e commented May 4, 2019

No, it is not Chrome-specific.
Pogo plugin uses custom wrapper, that relies on unsafeWindow.

Technically, it's easy to provide it.

Edit: I see you succeed in loading the plugin.
It's strange, because I've failed..

@modos189
Copy link
Contributor

modos189 commented May 4, 2019

In plugin
(typeof unsafeWindow != 'undefined' || typeof GM_info == 'undefined'...
GM_info is undefined, so plugin is executed as if the plugin is running in GreaseMonkey.

But now I've tested in IITC-Button 1.0.2 in Chrome and it works too. Is error somewhere deeper?

@johnd0e
Copy link

johnd0e commented May 5, 2019

I see now. AlfonsoML has already fixed the issue in plugin (see the history).

So no change required in IITC-Button.

@modos189
Copy link
Contributor

modos189 commented May 5, 2019

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants