New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent change to passworddialog.cpp #188

Closed
richtrefz opened this Issue Jul 7, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@richtrefz

richtrefz commented Jul 7, 2016

PasswordDialog::getPassword()
passFile += widget->objectName() + ": " + text + "\n";
(adding the space after the colon, I think version 1.1.2)

For me it results in a space added in front of UserName

I'm using a template with fields
UserName
URL

@annejan annejan added the bug label Jul 7, 2016

@annejan annejan self-assigned this Jul 7, 2016

@annejan

This comment has been minimized.

Member

annejan commented Jul 7, 2016

I'll probably have to trim the items, should be an easy fix.
Thank you for your quick detective work on this issue.

@richtrefz

This comment has been minimized.

richtrefz commented Jul 7, 2016

there were a number of str.trimmed() added as well. thought that would have nailed it, but ... My C++ is rusty.

And strangely it didn't seem to add the space in every case. I don't see the pattern to when it does or doesn't. I build qtpass on debian, so if you want me to test anything, please ask.

I was going to ask about copying other fields (in addition to password), but #133 looks like it covers it.

@YoshiMan

This comment has been minimized.

YoshiMan commented Nov 20, 2016

@annejan this issue should be already implemented, right?

@annejan

This comment has been minimized.

Member

annejan commented Nov 20, 2016

You are correct @YoshiMan
Closing issue, feel free to re-open with more info if something weird still happens @richtrefz . .

@annejan annejan closed this Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment