New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy password by Ctrl+C #60

Closed
karlgrz opened this Issue Jun 24, 2015 · 13 comments

Comments

Projects
None yet
2 participants
@karlgrz

karlgrz commented Jun 24, 2015

I will start by saying how much I am enjoying qtpass, it is a great ui for pass! Thanks for developing it!

It would be great to be able to highlight a password file in the tree and be able to Ctrl+C the password onto the clipboard instead of having to highlight it in the viewer on the right.

Does that make sense?

Again, thanks!

@annejan

This comment has been minimized.

Show comment
Hide comment
@annejan

annejan Jun 24, 2015

Member

Thanks for the compliments.
Would the "Clipboard" feature fix this?
screen shot 2015-06-24 at 19 17 26
It has an "Autoclear" timeout option as well..
Just click on the file on the left, and it gets copied to your clipboard, no Ctrl+C needed.

Member

annejan commented Jun 24, 2015

Thanks for the compliments.
Would the "Clipboard" feature fix this?
screen shot 2015-06-24 at 19 17 26
It has an "Autoclear" timeout option as well..
Just click on the file on the left, and it gets copied to your clipboard, no Ctrl+C needed.

@karlgrz

This comment has been minimized.

Show comment
Hide comment
@karlgrz

karlgrz Jun 24, 2015

Thanks for the quick reply!

That would be wonderful...if it worked ;-)

I'm on linux, compiled from source (version 0.8.4).

Using either Native git/gpg or pass, I get the same results. What seems to be happening is it just copies a blank line to the clipboard. The passwords I am trying -do- have the password as the first line.

I'd be happy to provide more information, or if you have another suggestion.

karlgrz commented Jun 24, 2015

Thanks for the quick reply!

That would be wonderful...if it worked ;-)

I'm on linux, compiled from source (version 0.8.4).

Using either Native git/gpg or pass, I get the same results. What seems to be happening is it just copies a blank line to the clipboard. The passwords I am trying -do- have the password as the first line.

I'd be happy to provide more information, or if you have another suggestion.

@annejan

This comment has been minimized.

Show comment
Hide comment
@annejan

annejan Jun 24, 2015

Member

Have just tried on my Arch Linux laptop (KDE as Window Manager) and it works for me.
What window manager are you using?
I would like to have this fail for me too . . so I can fix it.

Member

annejan commented Jun 24, 2015

Have just tried on my Arch Linux laptop (KDE as Window Manager) and it works for me.
What window manager are you using?
I would like to have this fail for me too . . so I can fix it.

@karlgrz

This comment has been minimized.

Show comment
Hide comment
@karlgrz

karlgrz Jun 24, 2015

Certainly!

I'm on Ubuntu 15.04, using Unity and lightdm.

karlgrz commented Jun 24, 2015

Certainly!

I'm on Ubuntu 15.04, using Unity and lightdm.

@karlgrz

This comment has been minimized.

Show comment
Hide comment
@karlgrz

karlgrz Jun 26, 2015

Tried this on another machine (my desktop at home) and am seeing the same behavior. It is also running Ubuntu 15.04, unity, and lightdm.

karlgrz commented Jun 26, 2015

Tried this on another machine (my desktop at home) and am seeing the same behavior. It is also running Ubuntu 15.04, unity, and lightdm.

@annejan

This comment has been minimized.

Show comment
Hide comment
@annejan

annejan Jun 26, 2015

Member

Downloading Ubuntu 15 iso to test on a VM.
The main issue is that I'm using the Qt cross-platform clipboard, which apparently is currently broken with Ubuntu. Adding options like Ctrl+C handling won't do a thing since it'll be using the same clipboard API.

I hope to be able to fix this or find a way to be able to patch things upstream, this should affect all Qt applications that use clipboard integration.

Will do some test and might even find a workaround this morning, will keep you updated.

Member

annejan commented Jun 26, 2015

Downloading Ubuntu 15 iso to test on a VM.
The main issue is that I'm using the Qt cross-platform clipboard, which apparently is currently broken with Ubuntu. Adding options like Ctrl+C handling won't do a thing since it'll be using the same clipboard API.

I hope to be able to fix this or find a way to be able to patch things upstream, this should affect all Qt applications that use clipboard integration.

Will do some test and might even find a workaround this morning, will keep you updated.

@annejan

This comment has been minimized.

Show comment
Hide comment
@annejan

annejan Jun 26, 2015

Member

I'm getting a warning about the GNOME keyring hijacking the GPG agent, which probably causes the copy and hide functionality to backfire, both using pass and in "native" mode.
screen shot 2015-06-26 at 11 29 20
Do you also get this warning?

Funny side note, the Virtualbox "Shared Clipboard" function also doesn't seem to work on Ubuntu 15.04

Member

annejan commented Jun 26, 2015

I'm getting a warning about the GNOME keyring hijacking the GPG agent, which probably causes the copy and hide functionality to backfire, both using pass and in "native" mode.
screen shot 2015-06-26 at 11 29 20
Do you also get this warning?

Funny side note, the Virtualbox "Shared Clipboard" function also doesn't seem to work on Ubuntu 15.04

@annejan

This comment has been minimized.

Show comment
Hide comment
@annejan

annejan Jun 26, 2015

Member

After following the instructions on http://wiki.gnupg.org/GnomeKeyring
Specifically adding X-GNOME-Autostart-enabled=false to ~/.config/autostart/gnome-keyring-gpg.desktop the clipboard integration works again.
screen shot 2015-06-26 at 11 53 19
I'll try and add a workaround for QtPass to ignore the warning since this also breaks the "shoulder surfing protection" features.

Member

annejan commented Jun 26, 2015

After following the instructions on http://wiki.gnupg.org/GnomeKeyring
Specifically adding X-GNOME-Autostart-enabled=false to ~/.config/autostart/gnome-keyring-gpg.desktop the clipboard integration works again.
screen shot 2015-06-26 at 11 53 19
I'll try and add a workaround for QtPass to ignore the warning since this also breaks the "shoulder surfing protection" features.

@karlgrz

This comment has been minimized.

Show comment
Hide comment
@karlgrz

karlgrz Jun 26, 2015

@annejan thanks for discovering this! I also get the warnings, but I disregarded them since the CLI worked fine. I will try this out!

karlgrz commented Jun 26, 2015

@annejan thanks for discovering this! I also get the warnings, but I disregarded them since the CLI worked fine. I will try this out!

@annejan

This comment has been minimized.

Show comment
Hide comment
@annejan

annejan Jun 26, 2015

Member

Well, using the GNOME keyring actually might have some advantages, so I will also (later) make sure that warnings like this don't matter for the overall handling of QtPass.
Since now these warnings also cause passwords to display when you might not want them to.

Changing from GNOME keyring to native GPG Agent got me a different popup for my GPG passphrase for example, so changing keyring is at own risk (but can be re-enabled just as easily).

Thank you for finding this issue, I'll make sure it is fixed for the standard Ubuntu 15.04 (with GNOME keyring enabled) in the next release. After that (and some testing) I'll close this issue.

Member

annejan commented Jun 26, 2015

Well, using the GNOME keyring actually might have some advantages, so I will also (later) make sure that warnings like this don't matter for the overall handling of QtPass.
Since now these warnings also cause passwords to display when you might not want them to.

Changing from GNOME keyring to native GPG Agent got me a different popup for my GPG passphrase for example, so changing keyring is at own risk (but can be re-enabled just as easily).

Thank you for finding this issue, I'll make sure it is fixed for the standard Ubuntu 15.04 (with GNOME keyring enabled) in the next release. After that (and some testing) I'll close this issue.

@karlgrz

This comment has been minimized.

Show comment
Hide comment
@karlgrz

karlgrz Jun 26, 2015

@annejan adding the config did work, but you're right, now my GNOME keyring caching doesn't enable at startup, so I have to enter my passphrase on every login (I tried rebooting and was prompted again).

That is great news, thank YOU! I'll keep an eye out for the next release.

karlgrz commented Jun 26, 2015

@annejan adding the config did work, but you're right, now my GNOME keyring caching doesn't enable at startup, so I have to enter my passphrase on every login (I tried rebooting and was prompted again).

That is great news, thank YOU! I'll keep an eye out for the next release.

annejan added a commit that referenced this issue Jul 8, 2015

annejan added a commit that referenced this issue Jul 8, 2015

@annejan

This comment has been minimized.

Show comment
Hide comment
@annejan

annejan Jul 8, 2015

Member

It all seems to work on both Ubuntu and other platforms.
Thanks again for reporting this issue. The current error messages will soon be hide-able in the config.

Member

annejan commented Jul 8, 2015

It all seems to work on both Ubuntu and other platforms.
Thanks again for reporting this issue. The current error messages will soon be hide-able in the config.

@annejan annejan closed this Jul 8, 2015

@karlgrz

This comment has been minimized.

Show comment
Hide comment
@karlgrz

karlgrz Jul 8, 2015

Works like a charm, thanks for the quick fix to this!

karlgrz commented Jul 8, 2015

Works like a charm, thanks for the quick fix to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment