New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issue #602:Add auto dark theme #642
Conversation
Have run the test cases all are passing except 6/10 of the LoansTest which doesn't pass in current develop branch too atleast for my devices they show that Error due to compose being busy. |
83d50db
to
2b9c46a
Compare
I can see something failed in the commits can I do something to fix it? |
@MohitMandalia feel free to have a look at it :) I'd appreciate it! |
I am talking about this PR like it shows that this failed somehow when you merged |
Hi @MohitMandalia I had to do force-push in develop in a hurry - I might overwritten your commits or something like that? Apologies, if that's case! Isn't the code for the Auto dark theme in |
Actually, it's in The lint check may be failing because it's executed on release build type or idk? (haven't investigated) However, I can confirm that your implementation is tested and works! |
Okok if it works fine then its ok. Let me know if anything has to be done I would love to help. I am browsing the issues though and I saw few of them but still feel free to tell me or give me an issue. |
@MohitMandalia that's awesome! Tbh, you know the issues better than me xD Last days I didn't have much time for the project. Feel free to pick any issue that you find interesting or want to work on. Also, if you have ideas for improving the app and make it better you're more to encouraged to develop them :) It's a community-driven and open-source project, and you're the ones to decide its future! |
Cool man that's really good to hear. Would surely check something out and if I get some good idea for improvements would surely work on the same. |
Hi @MohitMandalia if you're interested, you can have a look at #34 so we can implement attachments and automatic backups. That would be a killer feature and a great leap for our project! |
Definitely would love to help I'll check on it and see what can be done. |
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
develop
branch.androidTest
) and all tests are passingsuccessfully.
Important: Don't worry if you experience flaky UI tests. Just re-run the failed ones again and if they pass => it's all good!
Put an
x
in the boxes that apply.[x]
Pull Request Type
Please check the type of change your PR introduces:
Please check the type of change your PR introduces:
Put an
x
in the boxes that apply.Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
What's changed?
Describe with a few bullets what's new:
How to run Ivy Wallet's UI tests (
androidTest
)Connect Android Emulator
Method 1: Android Studio UI
com (androidTest)
packageRun 'Tests in 'com''
Note: If you've checked "Compact Middle Packages" the option will appear as
com.ivy.wallet (androidTest)
.Method 2: Gradle Wrapper
chmod +x gradlew
(Linux)./gradlew connectedDebugAndroidTest
Method 3: Fastlane
bundle install
bundle exec fastlane ui_tests