Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #602:Add auto dark theme #642

Merged
merged 1 commit into from Mar 28, 2022

Conversation

MohitMandalia
Copy link
Contributor

@MohitMandalia MohitMandalia commented Mar 26, 2022

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the develop branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • I confirm that I've run Ivy Wallet's UI tests (androidTest) and all tests are passing
    successfully.

Important: Don't worry if you experience flaky UI tests. Just re-run the failed ones again and if they pass => it's all good!

Put an x in the boxes that apply.

  • Demo: Checking checkbox using [x]

Pull Request Type

Please check the type of change your PR introduces:
Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, new lines, etc.)
  • Refactoring (no functional changes, renaming)
  • Small improvement (fix typo, UI fine-tune, change color or something small)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation (clarifying comments, KDoc)
  • Tests (Unit, Integration, UI tests)
  • Other (please describe):

Put an x in the boxes that apply.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

What's changed?

Describe with a few bullets what's new:

  • Added an Auto mode for changing the theme automatically as per default device theme.

How to run Ivy Wallet's UI tests (androidTest)

Connect Android Emulator

  • Pixel 5 API 29+ AVD emulator (recommended)
  • Pixel 3XL API 29+ AVD emulator (recommended)
  • Large screen physical device (might also work)

Method 1: Android Studio UI

  • Find com (androidTest) package
  • Right click
  • Run 'Tests in 'com''

Note: If you've checked "Compact Middle Packages" the option will appear as com.ivy.wallet (androidTest).

Method 2: Gradle Wrapper

  • chmod +x gradlew (Linux)
  • ./gradlew connectedDebugAndroidTest

Method 3: Fastlane

  • Install Ruby 2.7
  • bundle install
  • bundle exec fastlane ui_tests

@MohitMandalia
Copy link
Contributor Author

MohitMandalia commented Mar 26, 2022

Have run the test cases all are passing except 6/10 of the LoansTest which doesn't pass in current develop branch too atleast for my devices they show that Error due to compose being busy.

@ILIYANGERMANOV ILIYANGERMANOV merged commit 8a0d37d into Ivy-Apps:develop Mar 28, 2022
@MohitMandalia
Copy link
Contributor Author

I can see something failed in the commits can I do something to fix it?

@ILIYANGERMANOV
Copy link
Collaborator

@MohitMandalia feel free to have a look at it :) I'd appreciate it!

@MohitMandalia
Copy link
Contributor Author

I am talking about this PR like it shows that this failed somehow when you merged

@ILIYANGERMANOV
Copy link
Collaborator

Hi @MohitMandalia I had to do force-push in develop in a hurry - I might overwritten your commits or something like that? Apologies, if that's case! Isn't the code for the Auto dark theme in develop?

@ILIYANGERMANOV
Copy link
Collaborator

Actually, it's in main. Then it's all good!
9b23125

The lint check may be failing because it's executed on release build type or idk? (haven't investigated) However, I can confirm that your implementation is tested and works!

@MohitMandalia
Copy link
Contributor Author

Okok if it works fine then its ok. Let me know if anything has to be done I would love to help. I am browsing the issues though and I saw few of them but still feel free to tell me or give me an issue.

@ILIYANGERMANOV
Copy link
Collaborator

@MohitMandalia that's awesome! Tbh, you know the issues better than me xD Last days I didn't have much time for the project.

Feel free to pick any issue that you find interesting or want to work on. Also, if you have ideas for improving the app and make it better you're more to encouraged to develop them :)

It's a community-driven and open-source project, and you're the ones to decide its future!

@MohitMandalia
Copy link
Contributor Author

@MohitMandalia that's awesome! Tbh, you know the issues better than me xD Last days I didn't have much time for the project.

Feel free to pick any issue that you find interesting or want to work on. Also, if you have ideas for improving the app and make it better you're more to encouraged to develop them :)

It's a community-driven and open-source project, and you're the ones to decide its future!

Cool man that's really good to hear. Would surely check something out and if I get some good idea for improvements would surely work on the same.

@ILIYANGERMANOV
Copy link
Collaborator

Hi @MohitMandalia if you're interested, you can have a look at #34 so we can implement attachments and automatic backups. That would be a killer feature and a great leap for our project!

@MohitMandalia
Copy link
Contributor Author

Hi @MohitMandalia if you're interested, you can have a look at #34 so we can implement attachments and automatic backups. That would be a killer feature and a great leap for our project!

Definitely would love to help I'll check on it and see what can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants