Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRANSLATION] Introduce plurals for better UX #855

Closed
1 task done
llama-0 opened this issue May 6, 2022 · 3 comments
Closed
1 task done

[TRANSLATION] Introduce plurals for better UX #855

llama-0 opened this issue May 6, 2022 · 3 comments
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user

Comments

@llama-0
Copy link
Contributor

llama-0 commented May 6, 2022

Please confirm the following

What do you want to be added or improved?

Add plurals.

Why do you need it?

  • Different languages have different rules for grammatical agreement with quantity. So in order to translate app to different languages we need to add support for this quantity strings.
    Example:
    En - 1 day, 4 days, 5 days
    Ru - 1 день, 4 дня, 5 дней
  • With this feature we'll achieve better UX

How do you imagine it?

Here is a sample project for En-Ru to highlight what plurals are and how to work with them. Anyone can use it as a reference.
Here are official docs
I'll attach a list of candidates for plurals from the Ivy Wallet project later, based on Russian translation. Feel free to check it for other languages and add your suggestions.

@llama-0 llama-0 added the user request Feature/improvement requested by an user label May 6, 2022
@Pkcarreno
Copy link
Contributor

the project currently contains plural words

for example:

https://github.com/ILIYANGERMANOV/ivy-wallet/blob/00f595181648f782ec88c9d7f6e18f8145d21fcd/app/src/main/res/values/strings.xml#L419
https://github.com/ILIYANGERMANOV/ivy-wallet/blob/00f595181648f782ec88c9d7f6e18f8145d21fcd/app/src/main/res/values/strings.xml#L418

and others more.

but I don't understand if you mean the implementation of these, which I'm not very aware of.

@llama-0
Copy link
Contributor Author

llama-0 commented May 9, 2022

Hi, @Pkcarreno! It's not about words itself, it's about different representation of such words in different languages. For some languages there are more than 2 words for single and multiple.
Look at the example below
.../values/strings.xml
.../values-ru/strings.xml
So, for example, for a word "day" ("день") it would be:

  • English
    • 1 day
    • many (2, 5, 10, 100000, etc) days
  • Russian
    • 1 день
    • 2..4 дня
    • 5..20 дней
    • 21 день (notice, the end of the number is 1, so the representation is recurring)
    • 22 дня (same here for 2..4)
    • 25 дней (same here for 5..0)
      etc.

If you follow the link to official documentation, the issue should be clear. If not, please leave a comment, and we'll discuss it in more details, and I'll dig up some linguistic terminology.

@llama-0 llama-0 mentioned this issue May 13, 2022
7 tasks
@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Sep 1, 2023
@ILIYANGERMANOV
Copy link
Collaborator

Stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user
Projects
None yet
Development

No branches or pull requests

3 participants