Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code Reviewing Guidelines. #357

Closed
Madhuparna04 opened this issue Nov 2, 2022 · 2 comments
Closed

Add Code Reviewing Guidelines. #357

Madhuparna04 opened this issue Nov 2, 2022 · 2 comments
Assignees
@Boyuan-Tian

Comments

@Madhuparna04
Copy link

No description provided.

@Boyuan-Tian
Copy link
Contributor

Let’s pass it through everyone before adopting.
I am putting the link below. Please take a look and leave comments when you have a chance.

Guidelines for PR reviewer:
https://google.github.io/eng-practices/review/reviewer/

Guidelines for PR submitter:
https://google.github.io/eng-practices/review/developer/

@astro-friedel astro-friedel mentioned this issue Mar 11, 2024
Open
8 tasks
@astro-friedel
Copy link
Contributor

Closing as this issue has been combined with similar ones in #415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boyuan-Tian Boyuan-Tian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@astro-friedel @Boyuan-Tian @Madhuparna04