Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency on OpenCV #399

Closed
astro-friedel opened this issue Aug 18, 2023 · 0 comments · Fixed by #384
Closed

Reduce dependency on OpenCV #399

astro-friedel opened this issue Aug 18, 2023 · 0 comments · Fixed by #384
Assignees

Comments

@astro-friedel
Copy link
Contributor

Several of the plugins have a dependency on OpenCV, which is fine. However, due to the way the ILLIXR include files are structured most, if not all plugins and the main executable all depend on OpenCV.

For example:
main.cpp:
includes runtime_impl.hpp
includes stdout_record_logger.hpp
includes illixr/data_format.hpp
includes opencv2/core/mat.hpp
But main.cpp does not need openCV.

The ILLIXR includes should be restructured so that only those components which really need OpenCV are including it.

@astro-friedel astro-friedel self-assigned this Aug 31, 2023
@astro-friedel astro-friedel linked a pull request Aug 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant