Add human-readable logging infrastructure #44
Labels
design decision
Something we need public deliberation on
feature
New feature or request
good first issue
Good for newcomers
Projects
Our
record_logger
and the CPU timers in #209/#211 are good for computer-readable telemetry. However, we need an infrastructure for data intended to get to a user, such as warnings, error descriptions, and debugging messages.Perhaps, we should use glog.
LOG_EVERY_N
.assert(thing && msg)
can be replaced with glog'sCHECK(thing) << msg
.CHECK(thing) << getErrorMessage(msg)
which would not work with a rawassert
.CHECK
is not suppressed byNDEBUG
, which has caused us bugs in the past (and pesky[[maybe_unused]]
annotations).CHECK
with#ifndef NDEBUG
, as we do already in many places (e.g.common/record_logger.hpp
).catchsegv
. There's not a whole lot of benefit to switching over to glog for that.The text was updated successfully, but these errors were encountered: