fix(bhRendererDropdown): rebuild URL on selection

This commit instructs the bhRendererDropdown to rebuild the URL parameters when the users changes the dropdown menu selection. Closes #1239.
IMA-WorldHealth · Feb 21, 2017 · 0075e4c · 0075e4c
1 parent a882be1
commit 0075e4c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/client/src/js/components/bhRendererDropdown.js b/client/src/js/components/bhRendererDropdown.js
@@ -30,7 +30,8 @@ function bhRendererController(AppCache, $httpParamSerializer) {
 
   $ctrl.select = function select(option) {
     $ctrl.selection = option;
-    cache.selection = option;
+    cache.selection = $ctrl.selection;
+    combineAndSerializeParameters();
   };
 
   // watch for changes on the component's border and behave appropriately

diff --git a/client/src/partials/templates/bhRendererDropdown.tmpl.html b/client/src/partials/templates/bhRendererDropdown.tmpl.html
@@ -1,5 +1,5 @@
 <div class="btn-group" uib-dropdown>
-  <a class="btn btn-default" ng-href="{{::$ctrl.reportUrl}}?{{$ctrl.params}}" download>
+  <a class="btn btn-default" ng-href="{{$ctrl.reportUrl}}?{{$ctrl.params}}" download>
     <span ng-show="$ctrl.loading">
       <i class="fa fa-circle-notch-o"></i> <span translate>FORM.INFO.LOAING</span>
     </span>
@@ -12,7 +12,7 @@
     <span class="caret"></span>
   </a>
   <ul class="dropdown-menu" uib-dropdown-menu role="menu" aria-labelledby="single-button">
-    <li ng-repeat="option in ::$ctrl.options">
+    <li ng-repeat="option in $ctrl.options">
       <a href ng-click="$ctrl.select(option)">
         <i class="fa fa-{{::option.icon}}"></i>
         <span translate>{{ ::option.key }}</span>