Skip to content

Commit

Permalink
fix(events): remove event db writes production
Browse files Browse the repository at this point in the history
This commit removes writes to the db table until further notice.  This
is due to the remark that:
 1) massive numbers of events are being written
 2) events do not scale over multiple cores

This feature will be re-introduced when these are addressed and events
are needed to power client interactions.
  • Loading branch information
Jonathan Niles authored and sfount committed Dec 4, 2016
1 parent 46b3bda commit 0625072
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions server/lib/topic.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,14 @@ function databaseLogger(data) {
data: JSON.stringify(data)
};

/*
* @todo - in a week of operation on a small scale ~600 events were
* written. We are turning this off until we get a better idea of how
* to scale this.
db.exec('INSERT INTO event SET ?', [record])
.catch(err => winston.error(err))
.done();
.catch(err => winston.error(err))
.done();
*/
}

/**
Expand Down
2 changes: 1 addition & 1 deletion test/integration/system.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const helpers = require('./helpers');

describe('(/system) System Information', () => {

it('GET /system/events downloads a list of events', () => {
it.skip('GET /system/events downloads a list of events', () => {
return agent.get('/system/events')
.then((res) => {
expect(res).to.have.status(200);
Expand Down

0 comments on commit 0625072

Please sign in to comment.