fix(stock): force refresh grid index

This commit forces the grid to use the correct index by referencing it
in the HTML.  Previously, grid cells were being reused instead of being
updated.  By referencing the index directly, the grid responds with the
correct index.

Closes #2492.

client/src/modules/stock/StockForm.service.js

@@ -38,7 +38,7 @@ function StockFormService(StockItem, Store, AppCache, Session, $timeout) {
   StockForm.prototype.setup = function setup() {
     this.details = {
       date: new Date(),
-      user_id: Session.user.id
+      user_id: Session.user.id,
     };
   };
 
@@ -80,14 +80,14 @@ function StockFormService(StockItem, Store, AppCache, Session, $timeout) {
   StockForm.prototype.clear = function clear() {
     this.store.clear();
 
-    $timeout(function () {
+    $timeout(() => {
       this.setup();
 
       // validate() is only set up to test on submission as it checks the validity
       // of individual items which will not have been configured, manually
       // reset error state
       delete this._error;
-    }.bind(this));
+    });
   };
 
   /**

client/src/modules/stock/entry/entry.js

@@ -128,15 +128,7 @@ function StockEntryController(
   }
 
   function removeItem(index) {
-    const data = vm.gridOptions.data.filter((row, i)=>{
-      if(index !== i){
-        return true;
-      }
-      return false;
-    });
-    vm.gridOptions.data = data;
-    vm.stockForm.store.data = data;
-
+    vm.stockForm.removeItem(index);
     hasValidInput();
   }
 

client/src/modules/stock/entry/templates/actions.tmpl.html

@@ -1,3 +1,3 @@
 <div class="ui-grid-cell-contents text-center">
-  <a class="text-action" ng-click="grid.appScope.removeItem(grid.renderContainers.body.visibleRowCache.indexOf(row))" tabindex="-1"><i class="fa fa-trash-o text-danger"></i></a>
+  <a class="text-action" ng-click="grid.appScope.removeItem(row.entity.id)" tabindex="-1"><i class="fa fa-trash-o text-danger"></i></a>
 </div>