Skip to content

Commit

Permalink
fix(journal): do not close search on external click
Browse files Browse the repository at this point in the history
This commit fixes a usability issue that would automatically close the Journal Search modal when a
user clicked outside of it.  Users often clicked outside the search modal to try and dismiss a
dropdown, but ended up dismissing the entire modal.  Operating on the princple of least surprise
(and least frustration), the dismiss-on-external-click has been removed.

Closes #1617.
  • Loading branch information
jniles authored and sfount committed May 23, 2017
1 parent b9d9182 commit 93efa64
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 0 additions & 3 deletions client/src/modules/journal/journal.js
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,6 @@ function JournalController(Journal, Sorting, Grouping,

// @TODO investigate why footer totals aren't updated automatically on data change
vm.gridApi.core.notifyDataChange(uiGridConstants.dataChange.ALL);

// try to unfold groups
// try { grouping.unfoldAllGroups(); } catch (e) {}
})
.catch(errorHandler)
.finally(toggleLoadingIndicator);
Expand Down
1 change: 1 addition & 0 deletions client/src/modules/journal/journalConfig.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ function JournalConfigService(Modal) {
return Modal.open({
templateUrl: 'modules/journal/modals/search.modal.html',
controller: 'JournalSearchModalController as ModalCtrl',
backdrop : 'static',
resolve : {
filters : function () { return filters; }
}
Expand Down

0 comments on commit 93efa64

Please sign in to comment.