fix(reports): client-side validation Aged Debtors

This commit implements form validation on the Aged Debtors report. It also removes the old Aged Debtors code.
IMA-WorldHealth · Aug 4, 2017 · bf3a8a9 · bf3a8a9
1 parent f2e09a2
commit bf3a8a9
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 100 deletions.
diff --git a/client/src/modules/finance/reports/aged-debtors/aged-debtors.ctrl.js b/client/src/modules/finance/reports/aged-debtors/aged-debtors.ctrl.js
diff --git a/client/src/modules/finance/reports/aged-debtors/aged-debtors.html b/client/src/modules/finance/reports/aged-debtors/aged-debtors.html
diff --git a/client/src/modules/finance/reports/aged-debtors/aged-debtors.routes.js b/client/src/modules/finance/reports/aged-debtors/aged-debtors.routes.js
diff --git a/client/src/modules/finance/reports/aged-debtors/aged-debtors.service.js b/client/src/modules/finance/reports/aged-debtors/aged-debtors.service.js
diff --git a/client/src/modules/reports/generate/aged_debtors/aged_debtors.config.js b/client/src/modules/reports/generate/aged_debtors/aged_debtors.config.js
@@ -48,7 +48,7 @@ function AgedDebtorsConfigController($sce, Notify, SavedReports, AppCache, repor
       .catch(Notify.handleError);
   };
 
-  vm.onSelectPeriod =  function onSelectPeriod(period){
+  vm.onSelectPeriod = function onSelectPeriod(period) {
     vm.reportDetails.date = period.end_date;
   };
 
@@ -57,4 +57,4 @@ function AgedDebtorsConfigController($sce, Notify, SavedReports, AppCache, repor
       vm.reportDetails = angular.copy(cache.reportDetails);
     }
   }
-}
+}
diff --git a/client/src/modules/reports/generate/aged_debtors/aged_debtors.html b/client/src/modules/reports/generate/aged_debtors/aged_debtors.html
@@ -23,9 +23,10 @@ <h3 class="text-capitalize" translate>REPORT.AGED_DEBTORS.TITLE</h3>
         <div class="panel-body">
           <form name="ConfigForm" bh-submit="ReportConfigCtrl.preview(ConfigForm)" novalidate>
             <bh-report-period-select
-              periodId = "ReportConfigCtrl.reportDetails.date"
-              name = "period"
-              on-select-callback = "ReportConfigCtrl.onSelectPeriod(period)">
+              periodId="ReportConfigCtrl.reportDetails.date"
+              name="period"
+              on-select-callback="ReportConfigCtrl.onSelectPeriod(period)"
+              validation-trigger="ConfigForm.$submitted">
             </bh-report-period-select>
 
             <!-- included Total Zeros  -->
@@ -44,4 +45,4 @@ <h3 class="text-capitalize" translate>REPORT.AGED_DEBTORS.TITLE</h3>
       </div>
     </div>
   </div>
-</div>
+</div>
diff --git a/client/src/modules/templates/bhReportPeriodSelect.tmpl.html b/client/src/modules/templates/bhReportPeriodSelect.tmpl.html
@@ -5,7 +5,7 @@
     <label class="control-label" translate>
       {{ $ctrl.label }}
     </label>
-    <ui-select name="period_id" 
+    <ui-select name="period_id"
       ng-model="$ctrl.periodId"
       on-select="$ctrl.onSelect($item, $model)" required>
       <ui-select-match placeholder="{{ 'FORM.SELECT.PERIOD' | translate }}">{{$select.selected.monthYear}}</span></ui-select-match>
@@ -18,4 +18,4 @@
       <div ng-messages-include="modules/templates/messages.tmpl.html"></div>
     </div>
   </div>
-</div>
+</div>