fix(review): implement review corrections

This commit implements feedback from @sfount on the PR. The server was also scanned for errant `uuid()` calls instead of `uuid.v4()`.
IMA-WorldHealth · Jun 13, 2016 · c98b7e7 · c98b7e7
1 parent 436fe44
commit c98b7e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/client/src/js/services/system.js b/client/src/js/services/system.js
@@ -35,7 +35,7 @@ function SystemService($http, util) {
   }
 
   function handleErrorEvent(event) {
-    if (event.readyState == EventSource.CLOSED) {
+    if (event.readyState === EventSource.CLOSED) {
       console.log('Connection was closed.');
     }
   }

diff --git a/server/controllers/admin/suppliers.js b/server/controllers/admin/suppliers.js
@@ -91,7 +91,7 @@ function create(req, res, next) {
   const data = db.convert(req.body, ['creditor_uuid']);
 
   // provide uuid if the client has not specified
-  const uid = data.uuid || uuid();
+  const uid = data.uuid || uuid.v4();
   data.uuid = db.bid(uid);
 
   let sql =