Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor): Invoices Footer total should be text-right. #1009

Closed
jniles opened this issue Dec 2, 2016 · 0 comments · Fixed by #1017
Closed

(refactor): Invoices Footer total should be text-right. #1009

jniles opened this issue Dec 2, 2016 · 0 comments · Fixed by #1017
Assignees
@jniles
Labels
Refactor

Comments

@jniles
Copy link
Contributor

jniles commented Dec 2, 2016

The invoices footer is floated left, making it look out of sync with the currency text. It is also difficult to compare currency/numeric values that are not left aligned. See below:

invoicesfootertext
Fig 1: Invoice Footer Totals

This should be fixed in a refactor for a better UI.
@jniles jniles added the Refactor label Dec 2, 2016
@jniles jniles self-assigned this Dec 3, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Dec 3, 2016
fix(invoices): pretty footer total values
4b54f74 
This commit makes the invoice registry footer a bit nicer to look at -
the label is gone, and the currency is left aligned for easy reading.

Closes IMA-WorldHealth#1009.
@jniles jniles mentioned this issue Dec 3, 2016
Merged
4 tasks
jniles pushed a commit that referenced this issue Dec 3, 2016
@jniles
fix(invoices): pretty footer total values
7a49d91 
This commit makes the invoice registry footer a bit nicer to look at -
the label is gone, and the currency is left aligned for easy reading.

Closes #1009.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(invoices): pretty footer total values jniles/bhima
1 participant
@jniles