feat(cash): /references finds payment uuid by ref #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an API route to find a payment UUID by the human readable reference. Use it like this: 1. `GET /cash/references/:reference` - returns the uuid of a cash payment matching the reference if it exists. Otherwise, returns a 404 NOT FOUND error. There are accompanying integration tests to demonstrate functionality.
|
|
||
| /** | ||
| * retrieves cash payment uuids from a reference string (e.g. HBB123) | ||
| * GET /cash/references/:reference |
There was a problem hiding this comment.
Can you use jsdoc for comment.
There was a problem hiding this comment.
This is jsdoc syntax. The @description is optional if the first line is the description (src). Can you be more specific about what you'd like to see?
There was a problem hiding this comment.
@method or @function , @name, @param , @description, @example are missed.
|
@jniles |
|
Okay. I'm happy to add whatever comments you think are necessary. Otherwise, you can merge it. |
DedrickEnc
added a commit
that referenced
this pull request
Feb 23, 2016
feat(cash): /references finds payment uuid by ref
jniles
referenced
this pull request
in jniles/bhima
Jan 21, 2017
This commit fixes the patient activity report so that it uses proper identifiers. Note: there are some improvements that can be made to better MySQL performance - moving the LEFT JOIN out of the UNION and using the cached ids in the document_map. Closes #129.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an API route to find a payment UUID by the human
readable reference. Use it like this:
GET /cash/references/:reference- returns the uuid of a cashpayment matching the reference if it exists. Otherwise, returns a 404
NOT FOUND error.
There are accompanying integration tests to demonstrate functionality.