Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixation du Module Paiement #1445

Closed
patsonjunior opened this issue Mar 29, 2017 · 2 comments
Closed

Fixation du Module Paiement #1445

patsonjunior opened this issue Mar 29, 2017 · 2 comments
Assignees
@jniles @mbayopanda
Labels
Bug

Comments

@patsonjunior
Copy link

  1. Nous constatons que lorsqu'on veut payer une facture libéllée CDF en USD, la conversion est faite normalement mais sans afficher le taux de change utilisé.
    Suggestion: fixer le taux de change utilisé lors de la conversion.
    module paiement

  2. Nous constatons également que lorqu'on veut payer une facture en USD, après avoir cliquer sur "Soumettre", il est renvoyé un message d'erreur. Si possible de fixer en cas d'une veritable erreur lié au système.
    paiement facture en usd et msg erreur
@jniles jniles added the Bug label Mar 30, 2017
@mbayopanda mbayopanda self-assigned this Apr 5, 2017
@mbayopanda
Copy link
Contributor

Le taux de change est $0.00 parce que en realité c'est $0.0008 et le systeme a tendance à tronquer le nombre à deux chiffres après la virgule.

@jniles jniles self-assigned this Apr 7, 2017
@jniles
Copy link
Collaborator

jniles commented Apr 7, 2017

I'll take a look at this one.

jniles pushed a commit to jniles/bhima that referenced this issue Apr 10, 2017
fix(cash): remove fault SQL exception handlers
0cedf89 
This commit removes problematic SQL exception handlers from the
CalculateCashInvoiceBalances() stored procedure.  All exception handling
should be done with the `db.transaction()` framework ... having these
extra handler in the SQL code led to confusing error messages when
strict mode throws exceptions.

With these exceptions removed, and the Vanga database re-created, the
issues posting USD cash payments disappears.

Closes IMA-WorldHealth#1445.
@jniles jniles mentioned this issue Apr 10, 2017
Merged
4 tasks
sfount pushed a commit that referenced this issue Apr 11, 2017
@sfount
fix(cash): remove fault SQL exception handlers
f940cf9 
This commit removes problematic SQL exception handlers from the
CalculateCashInvoiceBalances() stored procedure.  All exception handling
should be done with the `db.transaction()` framework ... having these
extra handler in the SQL code led to confusing error messages when
strict mode throws exceptions.

With these exceptions removed, and the Vanga database re-created, the
issues posting USD cash payments disappears.

Closes #1445.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

@mbayopanda mbayopanda

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jniles @mbayopanda @patsonjunior