fix(account): uiSelect rendering bugs #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
fix-account-select-rendering-bugs
branch
from
ac2a69b
to
8b0b71f
Compare
This commit fixes rendering bugs with newer `uiSelect` and implements them on both the Simple Vouchers html file and the `bhAccountSelect` component. This issue is that `uiSelect`'s CSS selects all child `span` elements under the ui-select options rather than the first one. It sets them to be width `100%`, causing the browser to render any sibling elements unpredictably. This has been corrected by removing all children spans except for the main span element.
jniles
force-pushed
the
fix-account-select-rendering-bugs
branch
from
8b0b71f
to
c45c667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes rendering bugs with newer
uiSelectand implementsthem on both the Simple Vouchers html file and the
bhAccountSelectcomponent.
This issue is that
uiSelect's CSS selects all childspanelementsunder the ui-select options rather than the first one. It sets them to
be width
100%, causing the browser to render any sibling elementsunpredictably.
This has been corrected by removing all children spans except for the
main span element. We can safely upgrade to
ui-selectversions higherthan v0.17.
Before
After
