Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Trial Balance errors do not show transaction ids #1594

Closed
jniles opened this issue May 4, 2017 · 1 comment · Fixed by #1596
Closed

(bug) Trial Balance errors do not show transaction ids #1594

jniles opened this issue May 4, 2017 · 1 comment · Fixed by #1596
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Contributor

jniles commented May 4, 2017

The Trial Balance modal no longer shows the transaction ids affected by errors. See below:

notransactionids
Fig 1: No Transaction Ids in Danger Modal

This is critically important to being able to find and fix errors in the dataset. It should be fixed as soon as possible.h
@jniles jniles added the Bug label May 4, 2017
@jniles jniles self-assigned this May 4, 2017
@jniles
Copy link
Contributor Author

jniles commented May 4, 2017

I'll take this one. I think I last messed with the TB.

jniles pushed a commit to jniles/bhima that referenced this issue May 4, 2017
fix(journal): trial balance errors show trans_id
c4fbb5f 
The API to the Trial Balance changed for performance reasons, however, the error state was not
updated correctly and did not show the trans_ids affected by the errors.  This commit fixes that
issue.

Closes IMA-WorldHealth#1594.
jniles pushed a commit to jniles/bhima that referenced this issue May 4, 2017
fix(journal): trial balance errors show trans_id
359d937 
The API to the Trial Balance changed for performance reasons, however, the error state was not
updated correctly and did not show the trans_ids affected by the errors.  This commit fixes that
issue.

Closes IMA-WorldHealth#1594.
@jniles jniles mentioned this issue May 4, 2017
Merged
4 tasks
jniles added a commit that referenced this issue May 4, 2017
@jniles
fix(journal): trial balance errors show trans_id (#1596)
22c70f3 
The API to the Trial Balance changed for performance reasons, however, the error state was not
updated correctly and did not show the trans_ids affected by the errors.  This commit fixes that
issue.

Closes #1594.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: trial balance error does not render trans_id jniles/bhima
1 participant
@jniles