-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix journal transaction type #1616
Fix journal transaction type #1616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
return item; | ||
}); | ||
|
||
vm.typeList.forEach(function (type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do two loops here where one will do:
list.forEach(function (item) {
item.hrText = $translate.instant(item.text);
vm.mapOrigins[item.id] = item.text;
});
@@ -0,0 +1,3 @@ | |||
<div class="ui-grid-cell-contents" translate> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need translate here? Can you not use hrText
instead and avoid translate?
…into fix_journal_transaction_type
…into fix_journal_transaction_type
…into fix_journal_transaction_type
…into fix_journal_transaction_type
This PR fixes the issue #1609