Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Account Statement Feedback #1762

Closed
7 tasks done
jniles opened this issue Jun 5, 2017 · 1 comment
Closed
7 tasks done

refactor: Account Statement Feedback #1762

jniles opened this issue Jun 5, 2017 · 1 comment
Assignees
@jniles
Labels
Refactor

Comments

@jniles
Copy link
Contributor

jniles commented Jun 5, 2017 •
edited
Loading

We've analyzed the Account Statement as a team, and came up with the following suggestions:

  • Remove the word "totals" from the grid footer.
  • Order the records by date by default
  • By default, no need to show the account label/number
  • Need variance/difference between credits and debits in the footer
  • Need to the beginning balance in the top of the grid.
  • Put type: number on grid columns definition to enable proper sorting.
  • Implement SaveState
@jniles jniles added the Refactor label Jun 5, 2017
@jniles jniles self-assigned this Jun 5, 2017
@jniles
Copy link
Contributor Author

jniles commented Jun 5, 2017

I'll take this one.

@jniles jniles removed their assignment Aug 11, 2017
@jniles jniles self-assigned this Sep 26, 2017
jniles added a commit to jniles/bhima that referenced this issue Dec 11, 2017
@jniles
feat(Account Statement): implement SaveState
b150cf8 
This commit implements ui-grid's save state on the Account Statement
module.

Partially addresses IMA-WorldHealth#1762.
jniles added a commit to jniles/bhima that referenced this issue Dec 11, 2017
@jniles
feat(account statement): grid beginning balance
9a45cdf 
This commit adds the beginning balance to the Account Statement grid for
the period shown on the grid.  To do so, I had to add a new function to
the accounts service to search for the first date in a generic period
selection.

Closes IMA-WorldHealth#1762.
@jniles jniles mentioned this issue Dec 11, 2017
Merged
jniles added a commit to jniles/bhima that referenced this issue Dec 14, 2017
@jniles
feat(Account Statement): implement SaveState
569436d 
This commit implements ui-grid's save state on the Account Statement
module.

Partially addresses IMA-WorldHealth#1762.
jniles added a commit to jniles/bhima that referenced this issue Dec 14, 2017
@jniles
feat(account statement): grid beginning balance
23b3cf5 
This commit adds the beginning balance to the Account Statement grid for
the period shown on the grid.  To do so, I had to add a new function to
the accounts service to search for the first date in a generic period
selection.

Closes IMA-WorldHealth#1762.
jniles added a commit to jniles/bhima that referenced this issue Dec 17, 2017
@jniles
feat(Account Statement): implement SaveState
7d74317 
This commit implements ui-grid's save state on the Account Statement
module.

Partially addresses IMA-WorldHealth#1762.
jniles added a commit to jniles/bhima that referenced this issue Dec 17, 2017
@jniles
feat(account statement): grid beginning balance
01c9311 
This commit adds the beginning balance to the Account Statement grid for
the period shown on the grid.  To do so, I had to add a new function to
the accounts service to search for the first date in a generic period
selection.

Closes IMA-WorldHealth#1762.
bors bot added a commit that referenced this issue Dec 17, 2017
@bors
Merge #2388
8bfae6c 
2388: Complete account statement module r=jniles a=jniles

This PR completes all the work for the Account Statement module set out in the #1762.

 1. SaveState has been implemented on the grid.
 2. A grid footer shows:
  a. The number of records in the grid.
  b. The opening balance before the first record shown in the grid.
  c. The debits and credits summed.
  d. The difference between debits and credits.

Closes #1762.
bors bot added a commit that referenced this issue Dec 17, 2017
@bors
Merge #2388
f2d076f 
2388: Complete account statement module r=jniles a=jniles

This PR completes all the work for the Account Statement module set out in the #1762.

 1. SaveState has been implemented on the grid.
 2. A grid footer shows:
  a. The number of records in the grid.
  b. The opening balance before the first record shown in the grid.
  c. The debits and credits summed.
  d. The difference between debits and credits.

Closes #1762.
bors bot added a commit that referenced this issue Dec 17, 2017
@bors
Merge #2388
2e03636 
2388: Complete account statement module r=jniles a=jniles

This PR completes all the work for the Account Statement module set out in the #1762.

 1. SaveState has been implemented on the grid.
 2. A grid footer shows:
  a. The number of records in the grid.
  b. The opening balance before the first record shown in the grid.
  c. The debits and credits summed.
  d. The difference between debits and credits.

Closes #1762.
@bors bors bot closed this as completed in #2388 Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles