chore(tree): make bhima-nav a component #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
improve-tree-navigation
branch
2 times, most recently
from
ad6a844
to
77ffba9
Compare
| } | ||
|
|
||
| function selectUnit(unit) { | ||
|
|
||
| // Clear previous selection if it exists | ||
| if (vm.selectedUnit) { | ||
| vm.selectedUnit.selected = false; | ||
| if ($ctrl.selectedUnit) { |
There was a problem hiding this comment.
As we must have one selected unit at a time, why not to do :
unit.selected = true;
$ctrl.selectedUnit = unit;
There was a problem hiding this comment.
As we must have one selected unit at a time, why not to do :
unit.selected = true;
$ctrl.selectedUnit = unit;
There was a problem hiding this comment.
The code does do what you suggest. See lines 85 and 86, right below this check. This if statement is trying to make sure the previous unit.selected is false.
Or am I misunderstanding?
|
This comment will not block the PR, however this PR needs a rebase. |
This commit migrates the `bhimaNav` directive to a component architecture. The navigation component is now called `bhNavigation` and has been migrated to the `components/` directory. One additional improvement has been implemented from #44. The tree now searches through all paths for a match to the current url on change using a `String.includes()` to search for matches. Credit to @sfount for this suggestion.
jniles
force-pushed
the
improve-tree-navigation
branch
from
77ffba9
to
fe9edaf
Compare
|
@DedrickEnc, rebased. |
DedrickEnc
added a commit
that referenced
this pull request
Mar 11, 2016
chore(tree): make bhima-nav a component
jniles
referenced
this pull request
in jniles/bhima
Jan 26, 2017
This commit fixes the cash registry filter bar to give greater visual surface area when there are no filters present on the page. Closes #179.
DedrickEnc
pushed a commit
to DedrickEnc/bhima-2.X
that referenced
this pull request
Jan 27, 2017
This commit fixes the cash registry filter bar to give greater visual surface area when there are no filters present on the page. Closes IMA-WorldHealth#179.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the
bhimaNavdirective to a componentarchitecture. The navigation component is now called
bhNavigationandhas been migrated to the
components/directory.One additional improvement has been implemented from #44. The tree now
searches through all paths for a match to the current url on change
using a
String.includes()to search for matches. Credit to @sfountfor this suggestion.