Subsidy client #181
Merged
Subsidy client #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| service.delete = del; | ||
|
|
||
| /** | ||
| * @desc Get an id (optionnal) and return back a list of subsidies or an subsidy |
There was a problem hiding this comment.
This are really great comments!
One small thing: JavaScript doesn't have a type or object called Integer. Instead of writing @param {Integer} it would be better to write @param {Number}, since that is JavaScript's numerical type.
Otherwise, this is excellent code documentation!
|
I've completed an initial review of this code. In general, this code is very clean, has the best comments I've seen recently, and is very well developed. The The tests are breaking, but I think it is network issues with Travis. I've restarted the tests, and I'll let you know if I determine the problem. I've made a few suggestions. If you need any clarity, feel free to ask. Excellent PR! |
|
Codes improvement in relation to the various review |
|
LGTM. Once the test results come back positive, it can be merged. Thanks! |
jniles
added a commit
that referenced
this pull request
Mar 9, 2016
feat(subsidy): implement client-side code
jniles
referenced
this pull request
in jniles/bhima
Jan 21, 2017
This commit adds an algorithm to sort all references generated by the system. It parses the new identifier syntax and sorts on the integer values of the identifier. Closes #181.
bors bot
added a commit
that referenced
this pull request
Dec 23, 2017
2430: Update mailgun-js to the latest version 🚀 r=jniles a=greenkeeper[bot] ## Version **0.14.0** of [mailgun-js](https://github.com/bojand/mailgun-js) was just published. <table> <tr> <th align=left> Dependency </td> <td> mailgun-js </td> </tr> <tr> <th align=left> Current Version </td> <td> 0.13.1 </td> </tr> <tr> <th align=left> Type </td> <td> dependency </td> </tr> </table> The version **0.14.0** is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. It might be worth looking into these changes and trying to get this project onto the latest version of mailgun-js. If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update. --- <details> <summary>Commits</summary> <p>The new version differs by 11 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/a0c59cc90f4f0654bf386d1e447b511573c94171"><code>a0c59cc</code></a> <code>0.14.0</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/ca2e671b8b6879757881316638acc8da4407a9e2"><code>ca2e671</code></a> <code>style</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/086decdbb8bfea79337fd0d80d5e47137d95744b"><code>086decd</code></a> <code>Add standardjs, restructure tests and update to ES2015 (#181)</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/269c86e29c862c87f8b62b5a77123057b7a1bb38"><code>269c86e</code></a> <code>add email validation docs to readme</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/3e12f09a04752676a267f75b875914e2e7f15bb1"><code>3e12f09</code></a> <code>Update promises.md</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/808790cb53707595a50127c6e37f5f2efee977c1"><code>808790c</code></a> <code>Update send mime documentation. Fixes #171. Update dependancies. (#172)</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/6ff76e5bb6fc673649e164252fac30923f1b0aff"><code>6ff76e5</code></a> <code>remove comments in docs readme</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/91e419a8af0df069e09e598a80f3a945f2d12eaa"><code>91e419a</code></a> <code>update docs readme</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/ee86dc95150d630518ec8cf049e868d989c2b4a7"><code>ee86dc9</code></a> <code>fix spelling mistake</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/251dafd22a16b705992b7e3afa4cd50f78a0a240"><code>251dafd</code></a> <code>Merge pull request #163 from maxmatthews/master</code></li> <li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/e9745d0f0fb1165c0d5bf8294ade2e051f7339d4"><code>e9745d0</code></a> <code>Fix typo in readme.md</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/bojand/mailgun-js/compare/d82a5f51b9941a527d2c6b7543601bb1ad3ea56f...a0c59cc90f4f0654bf386d1e447b511573c94171">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴
bors bot
added a commit
that referenced
this pull request
Aug 8, 2018
3010: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]
## Version **1.90.1** of **snyk** was just published.
<table>
<tr>
<th align=left>
Dependency
</th>
<td>
<a target=_blank href=https://github.com/snyk/snyk>snyk</a>
</td>
</tr>
<tr>
<th align=left>
Current Version
</th>
<td>
1.90.0
</td>
</tr>
<tr>
<th align=left>
Type
</th>
<td>
dependency
</td>
</tr>
</table>
The version **1.90.1** is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of snyk.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
---
<details>
<summary>Release Notes</summary>
<strong>v1.90.1</strong>
<p>Bumps various deps:</p>
<ul>
<li>bump snyk-config to fix env merge issue</li>
<li>bump go plugin to update doc/typos</li>
<li>bump nuget plugin to get rid of an unneeded dep</li>
<li>bump python plugin to fix pipenv monitoring issue</li>
<li>bump sbt plugin to update 'debug' dep version</li>
</ul>
</details>
<details>
<summary>Commits</summary>
<p>The new version differs by 12 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/e14ab9eaf5ba6cc66751f3fc2803d54d354b6b6c"><code>e14ab9e</code></a> <code>Merge pull request #185 from snyk/fix/bump-deps</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/c6735e4f4ef5a44b9ae158687682193da284f3f8"><code>c6735e4</code></a> <code>Merge pull request #184 from snyk/chore/github-release</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ace19f7394a9500d34bdb2247a6d75e78601cf5a"><code>ace19f7</code></a> <code>Merge pull request #183 from snyk/chore/eslint</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f31602440e9740e73c1c8b659bd396ba4ceb29ac"><code>f316024</code></a> <code>fix: bump sbt plugin to update 'debug' dep version</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/2c79a4efd4580e251decbfa4587a5fd86f9e5155"><code>2c79a4e</code></a> <code>fix: bump python plugin to fix pipenv monitoring issue</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/975ca1ca1198c0eda61d60b586ce3d3702287e8e"><code>975ca1c</code></a> <code>fix: bump nuget plugin to get rid of an unneeded dep</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/828d579ff27d582635c1b1db4b15f50331c5d91f"><code>828d579</code></a> <code>fix: bump go plugin to update doc/typos</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/be8fa57983cf566c280d29d91a0d28814f14625e"><code>be8fa57</code></a> <code>fix: bump snyk-config to fix env merge issue</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b638a37c093ba7200da94fc5424bd2816874ca35"><code>b638a37</code></a> <code>chore: eslint instead of jscs</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/0bfeb0b06df49b9acd67a2bb27993313546d138c"><code>0bfeb0b</code></a> <code>chore: fix github-release for assets uploading</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/9312a048c1d27021b52a90d335a8f68d0a7f9db5"><code>9312a04</code></a> <code>Merge pull request #181 from snyk/chore/semantic-release</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6abdfd957d07337b86e0ba3aafb1e219e1083665"><code>6abdfd9</code></a> <code>chore: upgrade semantic-release, proper travis & appveyor setup</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/2a6938fe92377c99fe4991f0159a1e32e6e58834...e14ab9eaf5ba6cc66751f3fc2803d54d354b6b6c">full diff</a></p>
</details>
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Client side for Subsidy and Test E2E
@jniles @DedrickEnc