Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Purchase order functionality refactoring #1842

Closed
DedrickEnc opened this issue Jul 12, 2017 · 2 comments · Fixed by #2443
Closed

(refactor) Purchase order functionality refactoring #1842

DedrickEnc opened this issue Jul 12, 2017 · 2 comments · Fixed by #2443
Assignees
@jniles
Labels
Needs Discussion

Comments

@DedrickEnc
Copy link
Contributor

The purchase order is on master now, so here are some noticed problems when using the module

  1. The payment mode should be default on LORS DE L'ACHAT

  2. Change FORM.INFO.INVALID_ITEMS into FORM.ERRORS.INVALID_ITEMS and translate it

  3. Remove the button RETROUVER UN ARCTICLE or implement it

These points can be discussed to find the final task list
@DedrickEnc DedrickEnc changed the title Purchase order functionality refactoring (refactor) Purchase order functionality refactoring Jul 12, 2017
@jniles
Copy link
Collaborator

jniles commented Jul 12, 2017 •
edited
Loading

All those suggestions look good to me 👍

If someone is going to tackle this, they should also tackle #1063 which suggests improvements to the Purchase Order module.

@jniles jniles self-assigned this Jan 9, 2018
@jniles
Copy link
Collaborator

jniles commented Jan 9, 2018

I'll tackle this.

jniles added a commit to jniles/bhima that referenced this issue Jan 9, 2018
@jniles
fix(purchase): ui glitches in purchase orders
c7ef425 
This commit fixes the following issues:
 1. Payment defaults to "on purchase" instead of "on delivery"
 2. The button to fetch the cache has been removed.

Closes IMA-WorldHealth#1842.
@jniles jniles mentioned this issue Jan 9, 2018
Merged
bors bot added a commit that referenced this issue Jan 10, 2018
@bors
Merge #2441 #2443
1bc5b2c 
2441: chore: use "Management" suffix on names r=jniles a=jniles

This commit adds the "management" suffix to module names in English to ensure clarity when a user is selecting modules.

Closes #2435

2443: fix(purchase): ui glitches in purchase orders r=jniles a=jniles

This commit fixes the following issues:
 1. Payment defaults to "on purchase" instead of "on delivery"
 2. The button to fetch the cache has been removed.

Closes #1842.
@bors bors bot closed this as completed in #2443 Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Needs Discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(purchase): ui glitches in purchase orders jniles/bhima
2 participants
@jniles @DedrickEnc