Adding an update method for debtor group API #185

mbayopanda · 2016-03-09T21:45:44Z

This PR add an update methode "PUT" for the debtor group API

…into api_debtor_group

jniles · 2016-03-09T21:48:45Z

server/controllers/finance/debtorGroups.js

@@ -84,6 +87,54 @@ function create(req, res, next) {
 }

 /**
+* PUT /debtor_groups/:uuid
+*
+* @exemple


Nice comments! For future reference, the JSDoc tag name is @example, not @exemple. :).

jniles · 2016-03-09T21:58:01Z

@mbayopanda, just two comments and then LGTM.

Your integration tests fail with this error:

error: [ERROR] Error: ER_NO_REFERENCED_ROW_2: Cannot add or update a child row: a foreign key constraint fails (`bhima_staging`.`debitor_group`, CONSTRAINT `debitor_group_ibfk_4` FOREIGN KEY (`price_list_uuid`) REFERENCES `price_list` (`uuid`) ON DELETE CASCADE ON UPDATE CASCADE)

Perhaps the price list uuid isn't properly configured. Happy debugging!

mbayopanda · 2016-03-09T22:29:07Z

@jniles this line below (in server/models/update/synt.sql) are responsible of the fail at travais :

DROP TABLE IF EXISTS price_list;

It's delete all data in price_list table which are in server/models/test/data.sql

mbayopanda · 2016-03-09T22:31:47Z

@jniles I think the best practice is simply to write in a single place for data : in server/models/test/data.sql and for schema in server/models/schema.sql

jniles · 2016-03-09T23:17:02Z

@mbayopanda, thanks for the feedback!

I just created an issue (#186) about where to put schema versus data. I'll implement this change tomorrow morning and open a PR.

mbayopanda · 2016-03-10T01:18:43Z

@jniles We need to touch price list test (priceList.js) for fixing some expect statements.

jniles · 2016-03-10T07:51:32Z

server/controllers/finance/debtorGroups.js

+  .catch(next)
+  .done();
+
+  function findDebtorGroup(rows) {


Much better!

jniles · 2016-03-10T07:56:07Z

@mbayopanda, it looks like these changes broke the priceList tests. Go ahead and update them so that we have passing tests. It should be simple: changing lines like this one to expect the correct number of price lists.

LGTM!

mbayopanda · 2016-03-10T15:28:03Z

@jniles could you review this PR

jniles · 2016-03-10T15:35:06Z

LGTM.

Adding an update method for debtor group API

This commit implements a POS receipt for the voucher page. This receipt also puts the transaction type at the top of the receipt and groups by debits/credits. Fixes #184. Fixes #185.

3010: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## Version **1.90.1** of **snyk** was just published. <table> <tr> <th align=left> Dependency </th> <td> <a target=_blank href=https://github.com/snyk/snyk>snyk</a> </td> </tr> <tr> <th align=left> Current Version </th> <td> 1.90.0 </td> </tr> <tr> <th align=left> Type </th> <td> dependency </td> </tr> </table> The version **1.90.1** is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. It might be worth looking into these changes and trying to get this project onto the latest version of snyk. If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update. --- <details> <summary>Release Notes</summary> <strong>v1.90.1</strong> <p>Bumps various deps:</p> <ul> <li>bump snyk-config to fix env merge issue</li> <li>bump go plugin to update doc/typos</li> <li>bump nuget plugin to get rid of an unneeded dep</li> <li>bump python plugin to fix pipenv monitoring issue</li> <li>bump sbt plugin to update 'debug' dep version</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 12 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/e14ab9eaf5ba6cc66751f3fc2803d54d354b6b6c"><code>e14ab9e</code></a> <code>Merge pull request #185 from snyk/fix/bump-deps</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/c6735e4f4ef5a44b9ae158687682193da284f3f8"><code>c6735e4</code></a> <code>Merge pull request #184 from snyk/chore/github-release</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ace19f7394a9500d34bdb2247a6d75e78601cf5a"><code>ace19f7</code></a> <code>Merge pull request #183 from snyk/chore/eslint</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f31602440e9740e73c1c8b659bd396ba4ceb29ac"><code>f316024</code></a> <code>fix: bump sbt plugin to update 'debug' dep version</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/2c79a4efd4580e251decbfa4587a5fd86f9e5155"><code>2c79a4e</code></a> <code>fix: bump python plugin to fix pipenv monitoring issue</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/975ca1ca1198c0eda61d60b586ce3d3702287e8e"><code>975ca1c</code></a> <code>fix: bump nuget plugin to get rid of an unneeded dep</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/828d579ff27d582635c1b1db4b15f50331c5d91f"><code>828d579</code></a> <code>fix: bump go plugin to update doc/typos</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/be8fa57983cf566c280d29d91a0d28814f14625e"><code>be8fa57</code></a> <code>fix: bump snyk-config to fix env merge issue</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b638a37c093ba7200da94fc5424bd2816874ca35"><code>b638a37</code></a> <code>chore: eslint instead of jscs</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/0bfeb0b06df49b9acd67a2bb27993313546d138c"><code>0bfeb0b</code></a> <code>chore: fix github-release for assets uploading</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/9312a048c1d27021b52a90d335a8f68d0a7f9db5"><code>9312a04</code></a> <code>Merge pull request #181 from snyk/chore/semantic-release</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6abdfd957d07337b86e0ba3aafb1e219e1083665"><code>6abdfd9</code></a> <code>chore: upgrade semantic-release, proper travis & appveyor setup</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/2a6938fe92377c99fe4991f0159a1e32e6e58834...e14ab9eaf5ba6cc66751f3fc2803d54d354b6b6c">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>

mbayopanda added 2 commits March 9, 2016 22:28

Add a PUT method for the debtor group API

2db31e5

Merge branch 'master' of https://github.com/IMA-WorldHealth/bhima-2.X …

90a66f5

…into api_debtor_group

jniles reviewed Mar 9, 2016
View reviewed changes

jniles reviewed Mar 10, 2016
View reviewed changes

server/controllers/finance/debtorGroups.js

.catch(next)

.done();

function findDebtorGroup(rows) {

Copy link

Contributor

jniles Mar 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

Fix test data for travis

8a4cef1

mbayopanda force-pushed the api_debtor_group branch from 8e5118e to 8a4cef1 Compare March 10, 2016 14:43

jniles added a commit that referenced this pull request Mar 10, 2016

Merge pull request #185 from mbayopanda/api_debtor_group

d86614a

Adding an update method for debtor group API

jniles merged commit d86614a into IMA-WorldHealth:master Mar 10, 2016

mbayopanda deleted the api_debtor_group branch September 14, 2016 08:55

jniles referenced this pull request in jniles/bhima Feb 2, 2017

feat(vouchers): POS receipt

30d2ce2

This commit implements a POS receipt for the voucher page. This receipt also puts the transaction type at the top of the receipt and groups by debits/credits. Fixes #184. Fixes #185.

jniles referenced this pull request in jniles/bhima Feb 2, 2017

feat(vouchers): POS receipt

7e280a4

This commit implements a POS receipt for the voucher page. This receipt also puts the transaction type at the top of the receipt and groups by debits/credits. Fixes #184. Fixes #185.

jniles referenced this pull request in jniles/bhima Feb 2, 2017

feat(vouchers): POS receipt

798bfd8

This commit implements a POS receipt for the voucher page. This receipt also puts the transaction type at the top of the receipt and groups by debits/credits. Fixes #184. Fixes #185.

jniles referenced this pull request in jniles/bhima Feb 3, 2017

feat(vouchers): POS receipt

4d2ca89

This commit implements a POS receipt for the voucher page. This receipt also puts the transaction type at the top of the receipt and groups by debits/credits. Fixes #184. Fixes #185.

jniles referenced this pull request in jniles/bhima Feb 4, 2017

feat(vouchers): POS receipt

d9492f6

This commit implements a POS receipt for the voucher page. This receipt also puts the transaction type at the top of the receipt and groups by debits/credits. Fixes #184. Fixes #185.

jniles referenced this pull request in jniles/bhima Feb 4, 2017

feat(vouchers): POS receipt

7f3e5e8

This commit implements a POS receipt for the voucher page. This receipt also puts the transaction type at the top of the receipt and groups by debits/credits. Fixes #184. Fixes #185.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding an update method for debtor group API #185

Adding an update method for debtor group API #185

mbayopanda commented Mar 9, 2016

jniles Mar 9, 2016

jniles commented Mar 9, 2016

mbayopanda commented Mar 9, 2016

mbayopanda commented Mar 9, 2016

jniles commented Mar 9, 2016

mbayopanda commented Mar 10, 2016

jniles Mar 10, 2016

jniles commented Mar 10, 2016

mbayopanda commented Mar 10, 2016

jniles commented Mar 10, 2016

Adding an update method for debtor group API #185

Adding an update method for debtor group API #185

Conversation

mbayopanda commented Mar 9, 2016

jniles Mar 9, 2016

Choose a reason for hiding this comment

jniles commented Mar 9, 2016

mbayopanda commented Mar 9, 2016

mbayopanda commented Mar 9, 2016

jniles commented Mar 9, 2016

mbayopanda commented Mar 10, 2016

jniles Mar 10, 2016

Choose a reason for hiding this comment

jniles commented Mar 10, 2016

mbayopanda commented Mar 10, 2016

jniles commented Mar 10, 2016