Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Move all database changes into schema.sql or data.sql #186

Closed
jniles opened this issue Mar 9, 2016 · 0 comments
Closed

Proposal: Move all database changes into schema.sql or data.sql #186

jniles opened this issue Mar 9, 2016 · 0 comments
Labels
Needs Discussion

Comments

@jniles
Copy link
Contributor

jniles commented Mar 9, 2016

The bhima-2.X re-write is such a large departure from bhima-1.X, I propose we abandon maintaining the synt.sql script to migrate data forward. Instead, when we go to upgrade the 1.X database to the 2.X database, we will write our own custom SQL import scripts.

Before
Currently, we have three SQL scripts:

  1. schema.sql (data definition language)
  2. data.sql (test data)
  3. synt.sql (migration, some data definition language).

After

  1. schema.sql (data definition language + synt definitions)
  2. data.sql (test data + synt data)

@IMA-WorldHealth/local-contributors what do you think?
@jniles jniles changed the title Proposal: Move all database changes into schema.sql Proposal: Move all database changes into schema.sql or data.sql Mar 9, 2016
@jniles jniles mentioned this issue Mar 9, 2016
Merged
jniles referenced this issue in jniles/bhima Mar 10, 2016
@jniles
chore(db): build db from two files
d071add 
This commit remove synt.sql and ensures that the database is being built
only from the schema and test data files. This should make it much
easier and clearer when adding new data to the database.

All futher schema changes should occur in schema.sql, and all additional
data should be added to test.sql.

Closes #186.
@jniles jniles mentioned this issue Mar 10, 2016
Merged
jniles referenced this issue in jniles/bhima Mar 11, 2016
@jniles
chore(db): build db from two files
3eeddc8 
This commit remove synt.sql and ensures that the database is being built
only from the schema and test data files. This should make it much
easier and clearer when adding new data to the database.

All futher schema changes should occur in schema.sql, and all additional
data should be added to test.sql.

Closes #186.
jniles referenced this issue in jniles/bhima Mar 11, 2016
@jniles
chore(invoices): use bhDateEditor for date input
a9f0abd 
This commit introduces the bh-date-editor component to manage the
invoice date field.  The date is set to the current date using the
DateService.

Additionally, the following changes have taken place:
 1. Cleaned up PatientInvoiceService api slightly.
 2. [hack] Ensure that database builds billing services until #186
 lands, using `next.sql`.
jniles referenced this issue in jniles/bhima Mar 11, 2016
@jniles
chore(invoices): use bhDateEditor for date input
9ddb426 
This commit introduces the bh-date-editor component to manage the
invoice date field.  The date is set to the current date using the
DateService.

Additionally, the following changes have taken place:
 1. Cleaned up PatientInvoiceService api slightly.
 2. [hack] Ensure that database builds billing services until #186
 lands, using `next.sql`.
DedrickEnc pushed a commit to DedrickEnc/bhima-2.X that referenced this issue Jan 25, 2017
@jniles @sfount
feat(voucher): Patient Invoice Debt Transfer (IMA-WorldHealth#186)
7d08f3c 
* feat(voucher): Patient Invoice Debt Transfer

This commit implements a payment of a patient's debts via the Simple
Voucher module.  The debts are written off towards an account - in the
present use case, against an account belonging to a debtor group.

* fix(vouchers): implement clear() on form

This commit cleans up the form simple voucher form's worst hacks and
replaces them with _slightly_ cleaner code.  It also implements a
clear() button.

Closes IMA-WorldHealth#191.

* fix(currency): improve translation/rendering

This commit improves the bhCurrencyInput's translation and rendering by
making sure the currency is always rendered in uppercase and using the
more efficient translate directive instead of the translate filter.

* refactor(vouchers): SimpleVoucher use VoucherForm

This commit refactors the Simple Voucher module to use the VoucherForm.
The VoucherForm brings with it numerous advantages:
 1. Better error detection and handling
 2. Built-in caching.
 3. Cleaner separation of view/model

This makes the SimpleVoucher module much easier to extend and operate
in the future.

* fix(vouchers): fix e2e test

This commit fixes a case-sensitive issue in the simple vouchers form.

* fix(voucher): fix general bugs

This commit fixes the simple vouchers to have more maintainable code,
closes some tags, and makes sure that the appropriate values are
triggered when the scan barcode modal closes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles and others