Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Reword total debtor balance remaining on cash receipts #1931

Closed
sfount opened this issue Aug 3, 2017 · 0 comments · Fixed by #2075
Closed

(refactor) Reword total debtor balance remaining on cash receipts #1931

sfount opened this issue Aug 3, 2017 · 0 comments · Fixed by #2075
Assignees
@jniles
Labels
Refactor

Comments

@sfount
Copy link
Contributor

sfount commented Aug 3, 2017

Current cash receipt:
totals

I propose that we reword this to 'Debtor's remaining balance:' or something similar. Right now it ambiguous as to what balance is being referred to.
@sfount sfount added the Refactor label Aug 3, 2017
@jniles jniles self-assigned this Sep 1, 2017
jniles added a commit to jniles/bhima that referenced this issue Sep 2, 2017
@jniles
fix(i18n): clarify cash receipt balance text
b4e3b08 
This commit makes sure that the cash receipt properly labels the balance
as the debtor's balance instead of simply "Total Balance".  The previous
form was ambiguous about what balance it was referring to.

Closes IMA-WorldHealth#1931.
@jniles jniles mentioned this issue Sep 2, 2017
Merged
4 tasks
bors bot added a commit that referenced this issue Sep 12, 2017
@bors
Merge #2075
a08a67b 
2075: fix(i18n): clarify cash receipt balance text r=DedrickEnc a=jniles

This commit makes sure that the cash receipt properly labels the balance
as the debtor's balance instead of simply "Total Balance".  The previous
form was ambiguous about what balance it was referring to.

Closes #1931.

![fixdebtorremainingbalance](https://user-images.githubusercontent.com/896472/29997252-9e2bdb00-8fdc-11e7-9c9b-aa1a7e13bf20.png)
_Fig 1: New Text for Debtor's Remaining Balance_


---
jniles added a commit to jniles/bhima that referenced this issue Sep 12, 2017
@jniles
fix(i18n): clarify cash receipt balance text
73b9ecf 
This commit makes sure that the cash receipt properly labels the balance
as the debtor's balance instead of simply "Total Balance".  The previous
form was ambiguous about what balance it was referring to.

Closes IMA-WorldHealth#1931.
bors bot added a commit that referenced this issue Sep 15, 2017
@bors
Merge #2070 #2075
0a2a1e1 
2070: refactor(vouchers): improve registry code r=jniles a=jniles

This commit guts the voucher registry, removing a lot of legacy code and
ensuring that labels render correctly in both grouped and ungrouped
states.  The following components have been fixed:
 1. Fixed lint issues in the registry controller
 2. Removed the dropdown from group headers
 3. Fixed the label coloring in both grouped and ungrouped rows.

Closes #1952.

----



2075: fix(i18n): clarify cash receipt balance text r=jniles a=jniles

This commit makes sure that the cash receipt properly labels the balance
as the debtor's balance instead of simply "Total Balance".  The previous
form was ambiguous about what balance it was referring to.

Closes #1931.

![fixdebtorremainingbalance](https://user-images.githubusercontent.com/896472/29997252-9e2bdb00-8fdc-11e7-9c9b-aa1a7e13bf20.png)
_Fig 1: New Text for Debtor's Remaining Balance_


---
@bors bors bot closed this as completed in #2075 Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18n): clarify cash receipt balance text jniles/bhima
2 participants
@jniles @sfount