Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting date range for custom period is complex #1946

Closed
mbayopanda opened this issue Aug 9, 2017 · 3 comments
Closed

Setting date range for custom period is complex #1946

mbayopanda opened this issue Aug 9, 2017 · 3 comments
Assignees
@jniles

Comments

@mbayopanda
Copy link
Contributor

The default filters are used a lot (posting journal for example), so setting the date range for custom period is a long process for the user and sometime the Validating button is skipped or forgotten
@jniles
Copy link
Contributor

jniles commented Aug 9, 2017

Note, this can be tackled at the same time as #1940 and #1718.

@jniles
Copy link
Contributor

jniles commented Aug 17, 2017

Prior art: #1655.

@jniles jniles self-assigned this Oct 12, 2017
@jniles
Copy link
Contributor

jniles commented Oct 26, 2017

This is partially fixed - @jeremielodi implemented the logic so that the submit button can be skipped, but the button remains.

I'll remove it.

jniles added a commit to jniles/bhima that referenced this issue Oct 26, 2017
@jniles
fix(bhPeriodSelect): remove custom submit btn
30b57f1 
This commit remove the custom submit button required to register a
custom period.  With the button removed, it is no longer required or
possible to click the button to put in a custom period.  This applies
across all registries.

Closes IMA-WorldHealth#1946.
@jniles jniles mentioned this issue Oct 26, 2017
Merged
bors bot added a commit that referenced this issue Oct 27, 2017
@bors
Merge #2253
d927538 
2253: fix(bhPeriodSelect): remove custom submit btn r=DedrickEnc a=jniles

This commit remove the custom submit button required to register a custom period.  With the button removed, it is no longer required or possible to click the button to put in a custom period.  This applies
across all registries.

Closes #1946.
@bors bors bot closed this as completed in #2253 Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @mbayopanda