Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(journal voucher) : Automated description for prise en charge #1956

Closed
mbayopanda opened this issue Aug 9, 2017 · 0 comments
Closed

fix(journal voucher) : Automated description for prise en charge #1956

mbayopanda opened this issue Aug 9, 2017 · 0 comments
Assignees
@jniles

Comments

@mbayopanda
Copy link
Contributor

mbayopanda commented Aug 9, 2017 •
edited
Loading

Add an automated description for the prise en charge tool.

When the prise en charge tool is used, the description field in the journal voucher is not filled, the user is obliged to fill it manually.

This issue is about to fill the description field automatically with meaningful description when the prise en charge tool is used.
@jniles jniles self-assigned this Aug 19, 2017
jniles added a commit to jniles/bhima that referenced this issue Sep 4, 2017
@jniles
fix(vouchers): rework prise en charge
b8b26c0 
This commit cleans up the prise en charge voucher tool with refactors
from other modules.  It additionally adds in human readable description
text automatically on tool submission.

Closes IMA-WorldHealth#1956.
@jniles jniles mentioned this issue Sep 4, 2017
Merged
4 tasks
jniles added a commit to jniles/bhima that referenced this issue Sep 5, 2017
@jniles
fix(vouchers): rework prise en charge
21f8f6d 
This commit cleans up the prise en charge voucher tool with refactors
from other modules.  It additionally adds in human readable description
text automatically on tool submission.

Closes IMA-WorldHealth#1956.
jniles added a commit to jniles/bhima that referenced this issue Sep 12, 2017
@jniles
fix(vouchers): rework prise en charge
5d74ec0 
This commit cleans up the prise en charge voucher tool with refactors
from other modules.  It additionally adds in human readable description
text automatically on tool submission.

Closes IMA-WorldHealth#1956.
jniles added a commit to jniles/bhima that referenced this issue Sep 12, 2017
@jniles
fix(vouchers): rework prise en charge
508080d 
This commit cleans up the prise en charge voucher tool with refactors
from other modules.  It additionally adds in human readable description
text automatically on tool submission.

Closes IMA-WorldHealth#1956.
bors bot added a commit that referenced this issue Sep 16, 2017
@bors
Merge #2078
9d68918 
2078: refactor: complex voucher tools r=jniles a=jniles

This PR tracks work towards a large-scale refactor of Voucher Tools.  Each Voucher Tool is being revisited and rewritten to increase performance and address any reported bugs.  Duplicated code is being consolidated into shared services.

~~**Note** - This work is still ongoing and should not be merged yet.~~  This can now be merged anytime.

**Major Changes**
 1. Replace bhBreadcrumb with a simple headercrumb.  This change reduces the JS code by about 25 lines.  It also makes the voucher tools much easier to update, re-order, and change.  See #1923.
 2. Move shared code to the `VoucherToolKitService`.  This is particular evident with the `generateRow()` function that was used identically in ever controller.
 3. All forms that require accounts now use the `bhAccountSelect` component instead of manually downloading accounts themselves.
 4. Update Prise En Charge text.  Fixes #1956.
 5. Ensure modal ui-grids function correctly and more efficiently.
   a. Cost/balance sorting is now correct.
   b. Remove unnecessary cell templates (e.g. `balance.cell.html`)
   c. Consolidate `onSelectionChanged` listeners - reduces number of listeners by 50%.
   d. Consolidate aggregation functions into `aggregate()`.  No longer defines a new function on every selection change event.


-----
jniles added a commit to jniles/bhima that referenced this issue Sep 16, 2017
@jniles
fix(vouchers): rework prise en charge
a63f89d 
This commit cleans up the prise en charge voucher tool with refactors
from other modules.  It additionally adds in human readable description
text automatically on tool submission.

Closes IMA-WorldHealth#1956.
bors bot added a commit that referenced this issue Sep 16, 2017
@bors
Merge #2078
50ba24f 
2078: refactor: complex voucher tools r=mbayopanda a=jniles

This PR tracks work towards a large-scale refactor of Voucher Tools.  Each Voucher Tool is being revisited and rewritten to increase performance and address any reported bugs.  Duplicated code is being consolidated into shared services.

~~**Note** - This work is still ongoing and should not be merged yet.~~  This can now be merged anytime.

**Major Changes**
 1. Replace bhBreadcrumb with a simple headercrumb.  This change reduces the JS code by about 25 lines.  It also makes the voucher tools much easier to update, re-order, and change.  See #1923.
 2. Move shared code to the `VoucherToolKitService`.  This is particular evident with the `generateRow()` function that was used identically in ever controller.
 3. All forms that require accounts now use the `bhAccountSelect` component instead of manually downloading accounts themselves.
 4. Update Prise En Charge text.  Fixes #1956.
 5. Ensure modal ui-grids function correctly and more efficiently.
   a. Cost/balance sorting is now correct.
   b. Remove unnecessary cell templates (e.g. `balance.cell.html`)
   c. Consolidate `onSelectionChanged` listeners - reduces number of listeners by 50%.
   d. Consolidate aggregation functions into `aggregate()`.  No longer defines a new function on every selection change event.


-----
bors bot added a commit that referenced this issue Sep 16, 2017
@bors
Merge #2078
d9177f8 
2078: refactor: complex voucher tools r=mbayopanda a=jniles

This PR tracks work towards a large-scale refactor of Voucher Tools.  Each Voucher Tool is being revisited and rewritten to increase performance and address any reported bugs.  Duplicated code is being consolidated into shared services.

~~**Note** - This work is still ongoing and should not be merged yet.~~  This can now be merged anytime.

**Major Changes**
 1. Replace bhBreadcrumb with a simple headercrumb.  This change reduces the JS code by about 25 lines.  It also makes the voucher tools much easier to update, re-order, and change.  See #1923.
 2. Move shared code to the `VoucherToolKitService`.  This is particular evident with the `generateRow()` function that was used identically in ever controller.
 3. All forms that require accounts now use the `bhAccountSelect` component instead of manually downloading accounts themselves.
 4. Update Prise En Charge text.  Fixes #1956.
 5. Ensure modal ui-grids function correctly and more efficiently.
   a. Cost/balance sorting is now correct.
   b. Remove unnecessary cell templates (e.g. `balance.cell.html`)
   c. Consolidate `onSelectionChanged` listeners - reduces number of listeners by 50%.
   d. Consolidate aggregation functions into `aggregate()`.  No longer defines a new function on every selection change event.


-----
@bors bors bot closed this as completed in #2078 Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @mbayopanda