Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(journal voucher) : transaction type selection doesn't work properly #1957

Closed
mbayopanda opened this issue Aug 9, 2017 · 0 comments
Closed

fix(journal voucher) : transaction type selection doesn't work properly #1957

mbayopanda opened this issue Aug 9, 2017 · 0 comments
Assignees
@jniles
Labels
Bug

Comments

@mbayopanda
Copy link
Contributor

The transaction type selection doesn't work properly in some computers
@jniles jniles self-assigned this Oct 26, 2017
jniles added a commit to jniles/bhima that referenced this issue Oct 26, 2017
@jniles
fix(vouchers): autofocus ui-select input
b4c4393 
This commit implements the ui-select autofocus hack on the complex
voucher's ui-select.  When the dropdown is clicked, the input is now
selected.

Closes IMA-WorldHealth#1957.
@jniles jniles mentioned this issue Oct 26, 2017
Merged
bors bot added a commit that referenced this issue Oct 31, 2017
@bors
Merge #2255
6323469 
2255: fix(vouchers): complex voucher form glitches r=mbayopanda a=jniles

This commit implements the ui-select autofocus hack on the complex voucher's ui-select.  When the dropdown is clicked, the input is now selected.

Closes #1957.

This commit blocks submission of a complex voucher when there are no
items in the grid.  Previously, this logic was skipped .. it has been
moved further up in the chain to make sure that it gets called.

Partially addresses #2196.
@bors bors bot closed this as completed in #2255 Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @mbayopanda