Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Cash window gives no indication of only loading cash boxes from current project #1976

Closed
sfount opened this issue Aug 14, 2017 · 1 comment
Closed

(bug) Cash window gives no indication of only loading cash boxes from current project #1976

sfount opened this issue Aug 14, 2017 · 1 comment
Assignees
@jniles
Labels
Bug

Comments

@sfount
Copy link
Contributor

sfount commented Aug 14, 2017

The cash window currently selects only cash boxes from the users current project (chosen at sign in time). It can be very confusing to users to not see any cash boxes even though the configuration is set up with multiple cash boxes.

I think the two options are to clearly demonstrate that these are only the cash boxes that exist in the currently signed in to project, for example 'Hospital's cash boxes:' or to just show all cash boxes with the project shown next to the name.

I propose that for now we just show all cash boxes that exist with the project name next to the box - if hospital's become overwhelmed with multiple projects and cash boxes we can look at changing this in the future.

For example:

  • Cash Window (Hospital)
  • Primary Cash Box (Hospital)
  • Cash Window (Pharmacy)
@jniles jniles added the Bug label Aug 16, 2017
@jniles
Copy link
Contributor

jniles commented Aug 20, 2017

This is a really bad bug. In theory, if the hospital is not changing cashboxes all the time, showing all of them should be fine. If they were doing it a lot, the risk of them picking the wrong one is a lot higher.

@jniles jniles self-assigned this Aug 22, 2017
jniles added a commit to jniles/bhima that referenced this issue Aug 22, 2017
@jniles
fix(cashboxes): display all cashboxes in selection
3387e72 
This commit allows a user to select any project's cashbox from the
cashbox selection page.  As designed, BHIMA assumes that users will have
separate projects and use their own cashboxes, so those are cleanly
separated from the remaining cashboxes.  However, it does give the user
the possibility of using any registered cashbox.

Closes IMA-WorldHealth#1976.
@jniles jniles mentioned this issue Aug 22, 2017
Merged
jniles added a commit to jniles/bhima that referenced this issue Aug 22, 2017
@jniles
fix(cashboxes): display all cashboxes in selection
f2caea4 
This commit allows a user to select any project's cashbox from the
cashbox selection page.  As designed, BHIMA assumes that users will have
separate projects and use their own cashboxes, so those are cleanly
separated from the remaining cashboxes.  However, it does give the user
the possibility of using any registered cashbox.

Closes IMA-WorldHealth#1976.
bors bot added a commit that referenced this issue Aug 28, 2017
@bors
Merge #2036
73e69e9 
2036: fix(cashboxes): display all cashboxes in selection r=sfount a=jniles

This commit allows a user to select any project's cashbox from the
cashbox selection page.  As designed, BHIMA assumes that users will have
separate projects and use their own cashboxes, so those are cleanly
separated from the remaining cashboxes.  However, it does give the user
the possibility of using any registered cashbox.

Closes #1976.
@bors bors bot closed this as completed in #2036 Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount