New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(proposal) Underlying `EDITED` flag on financial entities #2047

Closed

sfount opened this issue Aug 23, 2017 · 1 comment

Assignees

Labels

Contributor

sfount commented Aug 23, 2017 •

edited

Loading

Currently there is no way of knowing if a BHIMA document has had its underlying transaction edited or changed during the posting process. There currently is not a use case for this however it may be useful to show on an invoice that the financial details of this document may have changed.

I propose that when an editing session is complete on a transaction it then uses the identifiers.js map to lookup the reference table and set an EDITED flag to TRUE .

The EDITED flag would be added to:

invoices
cash payments
vouchers

For example:

const transactionIdentifier = 'IV';
const documentTable = Identifiers[transactionIdentifier].table;

const sql = `UPDATE ${documentTable} SET edited = TRUE WHERE uuid = ?`;
db.exec(sql, transactionUuid)
  //...

The text was updated successfully, but these errors were encountered:

jniles added the proposal label

jniles self-assigned this

Contributor

jniles commented Nov 1, 2017

I'll take this one.

jniles added a commit to jniles/bhima that referenced this issue


          feat: implement EDITED flag on records

46befc8

This commit implements the EDITED flag on records of transactions that
have been modified via the posting journal edit tool.  This signals the
user that the transaction has been edited and the data might be out of
date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: add edited flag to client

78852c4

This commit adds the edited flag at the top of the record dropdowns for
cash, vouchers, and invoices.  The icon and text denote that the record
has been modified at the Journal and the receipt is likely out of date.

Closes IMA-WorldHealth#2047.

jniles mentioned this issue

Feat: edit flag on transactions #2276

Merged

jniles added a commit to jniles/bhima that referenced this issue


          feat: implement EDITED flag on records

0f36bb8

This commit implements the EDITED flag on records of transactions that
have been modified via the posting journal edit tool.  This signals the
user that the transaction has been edited and the data might be out of
date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: add edited flag to client

8eda286

This commit adds the edited flag at the top of the record dropdowns for
cash, vouchers, and invoices.  The icon and text denote that the record
has been modified at the Journal and the receipt is likely out of date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: implement EDITED flag on records

f9a3dd8

This commit implements the EDITED flag on records of transactions that
have been modified via the posting journal edit tool.  This signals the
user that the transaction has been edited and the data might be out of
date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: add edited flag to client

e42aff3

This commit adds the edited flag at the top of the record dropdowns for
cash, vouchers, and invoices.  The icon and text denote that the record
has been modified at the Journal and the receipt is likely out of date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: implement EDITED flag on records

414264c

This commit implements the EDITED flag on records of transactions that
have been modified via the posting journal edit tool.  This signals the
user that the transaction has been edited and the data might be out of
date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: add edited flag to client

7836e1c

This commit adds the edited flag at the top of the record dropdowns for
cash, vouchers, and invoices.  The icon and text denote that the record
has been modified at the Journal and the receipt is likely out of date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: implement EDITED flag on records

d95170f

This commit implements the EDITED flag on records of transactions that
have been modified via the posting journal edit tool.  This signals the
user that the transaction has been edited and the data might be out of
date.

Closes IMA-WorldHealth#2047.

jniles added a commit to jniles/bhima that referenced this issue


          feat: add edited flag to client

debc432

This commit adds the edited flag at the top of the record dropdowns for
cash, vouchers, and invoices.  The icon and text denote that the record
has been modified at the Journal and the receipt is likely out of date.

Closes IMA-WorldHealth#2047.

bors bot added a commit that referenced this issue


          Merge #2276

8e0dd7c

2276: Feat: edit flag on transactions r=DedrickEnc a=jniles

This PRimplements the EDITED flag on records of transactions that have been modified via the posting journal edit tool.  This signals the user that the transaction has been edited and the data might be out of
date.

This PR also improves the bhAutoDropup in some corner cases by accurately estimating the window size on startup and any resize events that occur. Previously, the first click might have an inaccurate window size. Furthermore, it implements debounce to ensure that the event loop is not blocked and the DOM is only manipulated a single time.

Finally, a client-side flag is added to the registries and it looks like this:
![editedrecordflag](https://user-images.githubusercontent.com/896472/32416624-dc23f51e-c254-11e7-8b5d-12d9a4b4f230.PNG)
_Fig 1: Edited Record Flag_

Closes #2047.

bors bot closed this as completed in #2276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment