Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Flaky Tests in Stock entry #2110

Closed
jniles opened this issue Sep 20, 2017 · 2 comments · Fixed by #2119
Closed

bug: Flaky Tests in Stock entry #2110

jniles opened this issue Sep 20, 2017 · 2 comments · Fixed by #2119
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Sep 20, 2017

The Stock Entry module still seems to have a flaky tests in master. See https://travis-ci.org/IMA-WorldHealth/bhima-2.X/builds/277753401 as an example of this.
@jniles jniles added the Bug label Sep 20, 2017
This was referenced Sep 21, 2017
Merged
Merged
@jniles
Copy link
Collaborator Author

jniles commented Sep 21, 2017

So .... This might actually be a bug in the depot tests. I think Depot Secondaire might be being deleted.

@jniles jniles self-assigned this Sep 21, 2017
@jniles
Copy link
Collaborator Author

jniles commented Sep 21, 2017

I'll tackle this. My assumption is that sort order is not stable for the depot page and it sometimes deletes the "Depot Secondaire" which is what the stock modules depend on. The depot test just uses an index to delete the depot. I'll try to change this to look up the depot by its text instead.

jniles added a commit to jniles/bhima that referenced this issue Sep 21, 2017
@jniles
fix(depots): depots deleted by name
83cdfd3 
This commit fixes the depots test to ensure that it only removes depots
by the correct name.  This is thought to contribute to IMA-WorldHealth#2110.

Closes IMA-WorldHealth#2110.
@jniles jniles mentioned this issue Sep 21, 2017
Merged
4 tasks
jniles added a commit to jniles/bhima that referenced this issue Sep 21, 2017
@jniles
fix(depots): depots deleted by name
cc26dc3 
This commit fixes the depots test to ensure that it only removes depots
by the correct name.  This is thought to contribute to IMA-WorldHealth#2110.

Closes IMA-WorldHealth#2110.
jniles added a commit to jniles/bhima that referenced this issue Sep 21, 2017
@jniles
fix(depots): depots deleted by name
46d47ae 
This commit fixes the depots test to ensure that it only removes depots
by the correct name.  This is thought to contribute to IMA-WorldHealth#2110.

Closes IMA-WorldHealth#2110.
jniles added a commit to jniles/bhima that referenced this issue Sep 22, 2017
@jniles
fix(depots): depots deleted by name
66f0d9b 
This commit fixes the depots test to ensure that it only removes depots
by the correct name.  This is thought to contribute to IMA-WorldHealth#2110.

Closes IMA-WorldHealth#2110.
bors bot added a commit that referenced this issue Sep 22, 2017
@bors
Merge #2119
c6184a1 
2119: fix(depots): depots deleted by name r=mbayopanda a=jniles

This commit fixes the depots test to ensure that it only removes depots
by the correct name.  This is thought to contribute to #2110.

Closes #2110.

----
jniles added a commit to jniles/bhima that referenced this issue Sep 22, 2017
@jniles
fix(depots): depots deleted by name
c96d1e2 
This commit fixes the depots test to ensure that it only removes depots
by the correct name.  This is thought to contribute to IMA-WorldHealth#2110.

Closes IMA-WorldHealth#2110.
bors bot added a commit that referenced this issue Sep 22, 2017
@bors
Merge #2119
4f5089a 
2119: fix(depots): depots deleted by name r=jniles a=jniles

This commit fixes the depots test to ensure that it only removes depots
by the correct name.  This is thought to contribute to #2110.

~~Closes #2110.~~

----
@bors bors bot closed this as completed in #2119 Sep 22, 2017
This was referenced Oct 4, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(depots): depots deleted by name jniles/bhima
1 participant
@jniles