-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new default filter for Journal: Show Full Transactions #2266
Labels
Comments
jniles
added a commit
to jniles/bhima
that referenced
this issue
Nov 5, 2017
The journal filters have been extended with the option to show the entire transaction following a search on the Journal. This extension gives the user the ability to not only find an account view, but also a full transaction view of all the data in the journal. Note that the implementation is quite heavy (requires two passes on the Journal). A warning message has been placed underneath the option to make the user aware of this. Closes IMA-WorldHealth#2266.
jniles
added a commit
to jniles/bhima
that referenced
this issue
Nov 5, 2017
The journal filters have been extended with the option to show the entire transaction following a search on the Journal. This extension gives the user the ability to not only find an account view, but also a full transaction view of all the data in the journal. Note that the implementation is quite heavy (requires two passes on the Journal). A warning message has been placed underneath the option to make the user aware of this. Closes IMA-WorldHealth#2266.
jniles
added a commit
to jniles/bhima
that referenced
this issue
Nov 5, 2017
The journal filters have been extended with the option to show the entire transaction following a search on the Journal. This extension gives the user the ability to not only find an account view, but also a full transaction view of all the data in the journal. Note that the implementation is quite heavy (requires two passes on the Journal). A warning message has been placed underneath the option to make the user aware of this. Closes IMA-WorldHealth#2266.
jniles
added a commit
to jniles/bhima
that referenced
this issue
Nov 5, 2017
The journal filters have been extended with the option to show the entire transaction following a search on the Journal. This extension gives the user the ability to not only find an account view, but also a full transaction view of all the data in the journal. Note that the implementation is quite heavy (requires two passes on the Journal). A warning message has been placed underneath the option to make the user aware of this. Closes IMA-WorldHealth#2266.
bors bot
added a commit
that referenced
this issue
Nov 9, 2017
2275: feat(journal): add showFullTransaction filter r=jniles a=jniles The journal filters have been extended with the option to show the entire transaction following a search on the Journal. This extension gives the user the ability to not only find an account view, but also a full transaction view of all the data in the journal. Note that the implementation is quite heavy (requires two passes on the Journal). A warning message has been placed underneath the option to make the user aware of this. Closes #2266. ![showfulltransactionoption](https://user-images.githubusercontent.com/896472/32417106-c7d08084-c25c-11e7-9c35-cf52175d98f0.png) _Fig 1: The modal for selecting transactions_ ![showfulltransactiongrid](https://user-images.githubusercontent.com/896472/32417105-c7138790-c25c-11e7-91ea-6a892db1fa16.png) _Fig 2: After filtering, the full transactions containing the query are shown_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I propose that we add a new default filter to the journal "Show Full Transactions". This would be a radio button with a value of "Yes" or "No".
The effect of this radio button would be to always show the full transaction record for all transactions matching the filter. For example, if you search for account 123 instead of just showing a single line with account 123 from each transaction, toggling
Show Full Transaction
toYes
would download the entire transaction for that has account 123 used in it.We could accomplish this by having a post-processing filter. After the regular filters have been applied, the Journal controller would get a unique list of record_uuids and simply filter on those transactions. It would be a two step process. If the user has not set the
Show Full Transactions
, this step would be skipped and the original filter would be sent.This has been requested by our clients in Vanga.
The text was updated successfully, but these errors were encountered: