Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the "Show Posted Transactions" in the Account Statement search. #2429

Closed
jniles opened this issue Dec 22, 2017 · 1 comment
Closed

Hide the "Show Posted Transactions" in the Account Statement search. #2429

jniles opened this issue Dec 22, 2017 · 1 comment
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Dec 22, 2017

The Account Statement module by definition shows only posted transactions. However, we have a checkbox on the module for including posted transactions ... and if checked, it breaks the page. Many users got tripped up on this.

I believe this bug stems from using the same search modal on the Journal and Account Statement. We should make sure that only the Journal has the "Show Posted Transactions" option.
@jniles jniles added the Bug label Dec 22, 2017
@jniles jniles self-assigned this Jan 9, 2018
@jniles
Copy link
Collaborator Author

jniles commented Jan 9, 2018

I'll take this one.

jniles added a commit to jniles/bhima that referenced this issue Jan 9, 2018
@jniles
fix(account statement): remove posted toggle
33dacbe 
The posted toggle should not be shown on the account statement since all
records are posted.  Having this option on the page can cause unexpected
behavior in production, so it is removed.

Closes IMA-WorldHealth#2429.
@jniles jniles mentioned this issue Jan 9, 2018
Merged
bors bot added a commit that referenced this issue Jan 15, 2018
@bors
Merge #2442
0164d69 
2442: fix(account statement): remove posted toggle r=jniles a=jniles

The posted toggle should not be shown on the account statement since all records are posted.  Having this option on the page can cause unexpected behavior in production, so it is removed.

Closes #2429.
@bors bors bot closed this as completed in #2442 Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles