Improvements to the General Ledger #2463
Comments
jniles
added a commit
to jniles/bhima
that referenced
this issue
Jan 26, 2018
This commit implements a check footer at the bottom of the grid that sums the values in the columns. As a rule of accounting, summing the chart of accounts should give a zero. Thus, any columns which do not sum to 0 denote a problem in the dataset. Closes IMA-WorldHealth#2463.
jniles
added a commit
to jniles/bhima
that referenced
this issue
Jan 26, 2018
This commit implements a check footer at the bottom of the grid that sums the values in the columns. As a rule of accounting, summing the chart of accounts should give a zero. Thus, any columns which do not sum to 0 denote a problem in the dataset. Closes IMA-WorldHealth#2463.
bors bot
added a commit
that referenced
this issue
Jan 29, 2018
2462: Refactor General Ledger r=mbayopanda a=jniles This PR refactors the General Ledger to make it more useful from an accounting perspective. **Code Refactor** 1. The server-side SQL query has been rewritten to be more performant and easier to read. In particular, the WHERE query filters on fiscal year instead of first looking up the periods in the fiscal year. 2. Removed the Account Slip code - it was essentially a duplication of effort from the Account Statement code. 3. Renamed all variables references `general-ledger-accounts` to `general-ledger`. We had folded the previous "General Ledger" into the Journal, so only this one remains. **Features** 1. A `<select>` element to the grid footer to use to switch the fiscal year and removes the Fiscal Year modal. This was requested by @WayneNiles and improves the UX by allowing users to switch fiscal years on the fly. By removing the modal, we also alleviate the maintenance burden on developers. 2. A "check row" at the bottom of the General Ledger has been implemented, showing the sum of each column with period balances. _These columns should always sum to zero_. If not, it means that there is an imbalanced transaction somewhere. 3. Title accounts are now show and hold the sum of the balances of their children. This allows a really quick comparison of bulk amounts, such as Income versus Expense. This has been implemented using a `Tree` class, available to be used in other reports. 4. Added title account highlighting and indentation to both the client and server-side generated reports for the General Ledger. The indentation is set to `15px` by default. 5. Add a link to the Account Statement module. This allows a user to directly inspect the values from the General Ledger in the Account Statement. **Screenshots**  _Fig 1: New General Ledger Client_  _Fig 2: New General Ledger Report w/ Indentation_ Closes #1706. Closes #2459. Closes #2463. Closes #2373.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once #2462 lands, we'll have a General Ledger that provides a view into the account totals by month, completely with summing of title accounts. However, there is still more work to be done!
<select>element is under the<bh-grid-loading-indicator>. We should find a way to make it accessible.The text was updated successfully, but these errors were encountered: