Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Inventory List ui-grid fill screen and no more #2499

Closed
jniles opened this issue Feb 2, 2018 · 1 comment
Closed

Make Inventory List ui-grid fill screen and no more #2499

jniles opened this issue Feb 2, 2018 · 1 comment
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Contributor

jniles commented Feb 2, 2018

The Inventory List ui-grid overflows the page resulting in two scroll bars. This is really annoying, since it hides the headers if you scroll to the bottom of the page. We should be able to fix this with a simply change of CSS classes on the grid itself.

See below:
twoscrollbarsinventory
Fig 1: What good are two scroll bars?!
@jniles jniles added the Bug label Feb 2, 2018
@jniles jniles self-assigned this Feb 2, 2018
@jniles jniles changed the title Make Inventory List ui-grid filll screen and no more Make Inventory List ui-grid fill screen and no more Feb 2, 2018
@jniles
Copy link
Contributor Author

jniles commented Feb 2, 2018

I'll tackle this while tackling #2493.

jniles added a commit to jniles/bhima that referenced this issue Feb 2, 2018
@jniles
fix(inventory): misc ui improvements.
dce11ed 
This commit:
 1. Adds a red trash icon to the delete option in the inventory list.
 2. Moves the "delete" option to the last option in the inventory list.
 3. Makes the inventory ui-grid always fit on the page.

Closes IMA-WorldHealth#2499. Closes IMA-WorldHealth#2493.
@jniles jniles mentioned this issue Feb 2, 2018
Merged
bors bot added a commit that referenced this issue Feb 2, 2018
@bors
Merge #2504 #2505
e89765b 
2504: fix(inventory): misc ui improvements. r=mbayopanda a=jniles

This commit:
 1. Adds a red trash icon to the delete option in the inventory list.
 2. Moves the "delete" option to the last option in the inventory list.
 3. Makes the inventory ui-grid always fit on the page.

Closes #2499. Closes #2493.

2505: feat(stock): allow moving lots registry columns r=mbayopanda a=jniles

This commit implements the ui-grid plugin to move columns on the stock lots registry.

Closes #2502.
@bors bors bot closed this as completed in #2504 Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles