Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Journal no longer caches filters #2521

Closed
jniles opened this issue Feb 7, 2018 · 0 comments · Fixed by #2528
Closed

The Journal no longer caches filters #2521

jniles opened this issue Feb 7, 2018 · 0 comments · Fixed by #2528
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Contributor

jniles commented Feb 7, 2018

It seems like all filters (at least the account filter) are no longer cached when you search from them in the Journal. They should be persistent unless they have the flag "cacheable" as "0".
@jniles jniles added the Bug label Feb 7, 2018
@jniles jniles self-assigned this Feb 8, 2018
jniles added a commit to jniles/bhima that referenced this issue Feb 8, 2018
@jniles
fix(journal): cache filters typo
14a28c0 
This commit fixes a typo that caused filters to no longer be cached on
the journal.  The code has also been improved by only checking for the
cacheable flag when the filter is attempting to be cached.  This avoids
having to add any values to the modules that use FilterService.

Additionally, I've updated all files I've manipulated to pass ESLint.

Closes IMA-WorldHealth#2521.
@jniles jniles mentioned this issue Feb 8, 2018
Merged
bors bot added a commit that referenced this issue Feb 8, 2018
@bors
Merge #2528
898f3f4 
2528: fix(journal): cache filters typo r=jniles a=jniles

This commit fixes a typo that caused filters to no longer be cached on the journal.  The code has also been improved by only checking for the cacheable flag when the filter is attempting to be cached.  This avoids
having to add any values to the modules that use FilterService.

Additionally, I've updated all files I've manipulated to pass ESLint.

Closes #2521.
@bors bors bot closed this as completed in #2528 Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(journal): cache filters typo jniles/bhima
1 participant
@jniles