Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the "title" attribute on long text fields in handlebars reports #2526

Closed
jniles opened this issue Feb 8, 2018 · 1 comment
Closed

Set the "title" attribute on long text fields in handlebars reports #2526

jniles opened this issue Feb 8, 2018 · 1 comment
Assignees
@jniles
Labels
Feature Request

Comments

@jniles
Copy link
Contributor

jniles commented Feb 8, 2018

On reports with large text fields, such as the description fields for almost all account reports, we should set the "title" attribute on the report handlebars. This will allow a user to peek at the text simply by hovering their mouse over it. An example of hidden text is shown below:

needstitleondescription
Fig 1: It would be nice to peek at some of these descriptions
@jniles jniles self-assigned this Feb 8, 2018
@jniles
Copy link
Contributor Author

jniles commented Feb 8, 2018

I'll tackle this.

jniles added a commit to jniles/bhima that referenced this issue Feb 8, 2018
@jniles
fix(reports): add title attribute
6f56f3a 
This commit adds the HTML title attribute to select reports that run the
risk of missing elements due to small screen sizes.  This title will
only appear when the mouse hovers over the text, specifically on the
report HTML preview.

Closes IMA-WorldHealth#2526.
@jniles jniles mentioned this issue Feb 8, 2018
Merged
bors bot added a commit that referenced this issue Feb 8, 2018
@bors
Merge #2531
a8d3b96 
2531: fix(reports): add title attribute r=jniles a=jniles

This commit adds the HTML title attribute to select reports that run the risk of missing elements due to small screen sizes.  This title will only appear when the mouse hovers over the text, specifically on the report HTML preview.

Closes #2526.
bors bot added a commit that referenced this issue Feb 8, 2018
@bors
Merge #2531
3820595 
2531: fix(reports): add title attribute r=jniles a=jniles

This commit adds the HTML title attribute to select reports that run the risk of missing elements due to small screen sizes.  This title will only appear when the mouse hovers over the text, specifically on the report HTML preview.

Closes #2526.
@bors bors bot closed this as completed in #2531 Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles