Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Server posting journal core [Journal Vouchers] #313

Closed
5 of 6 tasks
jniles opened this issue Apr 14, 2016 · 0 comments
Closed
5 of 6 tasks

(Feature) Server posting journal core [Journal Vouchers] #313

jniles opened this issue Apr 14, 2016 · 0 comments

Comments

@jniles
Copy link
Collaborator

jniles commented Apr 14, 2016

This issue is to track progress implementing the posting journal server-side core, responsible for posting transactions to the posting journal. The initial implementation will only involve posting vouchers to the posting journal, and will be expanded with utilities for posting from other tables.

Development Steps

  • Change the structure of the voucher table as recommended by Proposal: Modify Journal Vouchers to support multiple document references #280 and (Design) "Complex" Journal Vouchers #301.
  • Create the journal core.js file that will compute things like daily exchange rate, enterprise id, etc...
  • Create the journal voucher.js file that will perform the copy from voucher -> posting_journal.
  • Pass the transaction from the voucher controller to the journal/core, then to journal/voucher, and finally attach error handling.
  • Write integration tests to ensure that the posting process works properly.
  • Test edge cases - missing exchange rates, debit/credit imbalances, missing accounts, etc.
jniles referenced this issue in jniles/bhima Apr 15, 2016
This commit tests and edge case where the journal voucher will not have
a fiscal year, an error state thrown in the database and reformatted in
JavaScript.  It shows that the posting process does proper error
handling.

I've also cleaned up the comments for documentation purposes.

Closes #313.
bors bot added a commit that referenced this issue Jan 8, 2019
3530: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.120.1` to `1.121.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v1.121.0</summary>

<h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.120.1...v1.121.0">1.121.0</a> (2019-01-08)</h1>
<h3>Features</h3>
<ul>
<li>Split dockerfile / base image vulns (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530d">b2f530d</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 4 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ecac358cc1da7cee3715e709cfa368838c598af6"><code>ecac358</code></a> <code>Merge pull request #313 from snyk/feat/docker-split-user-base-vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530db922c85eed0de6139512e6eb83cb174fa"><code>b2f530d</code></a> <code>feat: Split dockerfile / base image vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/5f6083bb2f4dd80ecd7a3f4f7c8a16aa00f7eb58"><code>5f6083b</code></a> <code>Merge pull request #321 from snyk/chore/disable-lockfile-creation</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/95be92c862655fdda539056893336c4eb05582e3"><code>95be92c</code></a> <code>chore: Disable lockfile creation</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/5938f576c782762d1cbaa9cd4d10afa7dde3b91b...ecac358cc1da7cee3715e709cfa368838c598af6">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit that referenced this issue Jan 9, 2019
3530: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.120.1` to `1.121.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v1.121.0</summary>

<h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.120.1...v1.121.0">1.121.0</a> (2019-01-08)</h1>
<h3>Features</h3>
<ul>
<li>Split dockerfile / base image vulns (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530d">b2f530d</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 4 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ecac358cc1da7cee3715e709cfa368838c598af6"><code>ecac358</code></a> <code>Merge pull request #313 from snyk/feat/docker-split-user-base-vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530db922c85eed0de6139512e6eb83cb174fa"><code>b2f530d</code></a> <code>feat: Split dockerfile / base image vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/5f6083bb2f4dd80ecd7a3f4f7c8a16aa00f7eb58"><code>5f6083b</code></a> <code>Merge pull request #321 from snyk/chore/disable-lockfile-creation</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/95be92c862655fdda539056893336c4eb05582e3"><code>95be92c</code></a> <code>chore: Disable lockfile creation</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/5938f576c782762d1cbaa9cd4d10afa7dde3b91b...ecac358cc1da7cee3715e709cfa368838c598af6">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit that referenced this issue Jan 10, 2019
3530: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.120.1` to `1.121.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v1.121.0</summary>

<h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.120.1...v1.121.0">1.121.0</a> (2019-01-08)</h1>
<h3>Features</h3>
<ul>
<li>Split dockerfile / base image vulns (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530d">b2f530d</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 4 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ecac358cc1da7cee3715e709cfa368838c598af6"><code>ecac358</code></a> <code>Merge pull request #313 from snyk/feat/docker-split-user-base-vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530db922c85eed0de6139512e6eb83cb174fa"><code>b2f530d</code></a> <code>feat: Split dockerfile / base image vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/5f6083bb2f4dd80ecd7a3f4f7c8a16aa00f7eb58"><code>5f6083b</code></a> <code>Merge pull request #321 from snyk/chore/disable-lockfile-creation</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/95be92c862655fdda539056893336c4eb05582e3"><code>95be92c</code></a> <code>chore: Disable lockfile creation</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/5938f576c782762d1cbaa9cd4d10afa7dde3b91b...ecac358cc1da7cee3715e709cfa368838c598af6">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



3537: fix(journal): preserve trans_id_reference_number r=jniles a=jniles

We now remember the trans_id_reference_number when we create new lines in a transaction.  This means we no longer error when trying to add new lines to a transaction.

Note that we still need to add a test.

Partially addresses #3536.

Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
bors bot added a commit that referenced this issue Jan 10, 2019
3530: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.120.1` to `1.121.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v1.121.0</summary>

<h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.120.1...v1.121.0">1.121.0</a> (2019-01-08)</h1>
<h3>Features</h3>
<ul>
<li>Split dockerfile / base image vulns (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530d">b2f530d</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 4 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ecac358cc1da7cee3715e709cfa368838c598af6"><code>ecac358</code></a> <code>Merge pull request #313 from snyk/feat/docker-split-user-base-vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530db922c85eed0de6139512e6eb83cb174fa"><code>b2f530d</code></a> <code>feat: Split dockerfile / base image vulns</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/5f6083bb2f4dd80ecd7a3f4f7c8a16aa00f7eb58"><code>5f6083b</code></a> <code>Merge pull request #321 from snyk/chore/disable-lockfile-creation</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/95be92c862655fdda539056893336c4eb05582e3"><code>95be92c</code></a> <code>chore: Disable lockfile creation</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/5938f576c782762d1cbaa9cd4d10afa7dde3b91b...ecac358cc1da7cee3715e709cfa368838c598af6">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant