-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the gain/loss on rounding accounts to the enterprise
entity
#327
Labels
Comments
No problem with this. It seems to me having multiple gain/loss on exchange accounts would be overly complex from the accounting perspective, even if we could support it. |
jniles
referenced
this issue
in jniles/bhima
Apr 19, 2016
This commit implements the initial cash posting journal route by porting journal/voucher.js to the journal/cash.js. It also implements the following optimizations/cleanups: 1) The @Date, @currencyId, @enterpriseId, and @projectid are all performed in a single SQL `SELECT ... INTO` statement for both the cash and voucher posting. This improves readability and performance. 2) `gain_account_id` and `loss_account_id` are implemented as an enterprise setting, as required by #327 and requested in #324. In a future commit, the gain/loss accounts should be removed from the cashboxes. Closes #327.
jniles
referenced
this issue
in jniles/bhima
Apr 19, 2016
This commit refactors cashboxes to no longer manage the gain/loss on exchange accounts and implements suggestions found in #327.
jniles
referenced
this issue
in jniles/bhima
Apr 20, 2016
This commit implements the initial cash posting journal route by porting journal/voucher.js to the journal/cash.js. It also implements the following optimizations/cleanups: 1) The @Date, @currencyId, @enterpriseId, and @projectid are all performed in a single SQL `SELECT ... INTO` statement for both the cash and voucher posting. This improves readability and performance. 2) `gain_account_id` and `loss_account_id` are implemented as an enterprise setting, as required by #327 and requested in #324. In a future commit, the gain/loss accounts should be removed from the cashboxes. Closes #327.
4 tasks
bors bot
added a commit
that referenced
this issue
Jan 11, 2019
3538: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.121.0` to `1.122.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.122.0</summary> <h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.121.1...v1.122.0">1.122.0</a> (2019-01-10)</h1> <h3>Bug Fixes</h3> <ul> <li>Undefined base image (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/962810a">962810a</a>)</li> </ul> <h3>Features</h3> <ul> <li>send docker image layers SHAs (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/0827c2e">0827c2e</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 8 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/a8c561dbc5d343127ef485b93e9e2f807c5dae8a"><code>a8c561d</code></a> <code>Merge pull request #327 from snyk/fix/undefined-base-image</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/962810abd641d46c303b9ceb54ef0caac82cf5cf"><code>962810a</code></a> <code>fix: Undefined base image</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/bc828428c262ea7c63a5e156ade15a72bea2353c"><code>bc82842</code></a> <code>Merge pull request #325 from snyk/chore/run-travis-on-node-10</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/32d1d8c3415627a673a92f9abd7088cc2991ff95"><code>32d1d8c</code></a> <code>chore: Run CI against Node 10 (current LTS)</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/2e80014bad633be78c92ad10c173694bfe2f5621"><code>2e80014</code></a> <code>Merge pull request #323 from snyk/feat/send-docker-image-layers-shas</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f5a01ea36f08729f1fdcb377cb5c6dc383419208"><code>f5a01ea</code></a> <code>Merge pull request #324 from snyk/fix/bump_gradle_plugin</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/518a4becfe4df6285a8bdd041fddc2eb3af3350e"><code>518a4be</code></a> <code>fix: bumping snyk-gradle-plugin</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/0827c2edecbb662559e858dae5604786b35fd96c"><code>0827c2e</code></a> <code>feat: send docker image layers SHAs</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/ecac358cc1da7cee3715e709cfa368838c598af6...a8c561dbc5d343127ef485b93e9e2f807c5dae8a">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I propose, and will soon be implementing, moving the gain/loss on exchange accounts to the
enterprise
entity, under the columnsenterprise.gain_account_id
enterprise.loss_account_id
Previously, the gain/loss exchange accounts were tied to cashboxes, but in practice, there was never a need to have more than one gain and one loss account (OHADA requires that you separate them).
If anyone comes up with any downsides, please leave a comment. Otherwise, this issue will be closed when the relevant commit lands closing it.
The text was updated successfully, but these errors were encountered: