feat: bhSubmit checks for promises #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change LGTM. It seems there a number of modules that do not do their own Should those be changed here or should we leave it up to the module developers to update given this change? EDIT: Actually the only module I've found after doing a number of searches is |
|
@sfount, I would leave it up to the module developers. That will give us a reason to go through and write tests that check for the proper error handling. To do that here would be a rather big change for a small proposal. Do you agree? |
|
Sounds good to me! |
This commit implements the suggestions proposed in #431. The `bhSubmit` directive responsible for toggle the form's $loading state now supports inputs other than Promises. If the input is not a promise, the form immediately cancels the $loading state. Otherwise, the $loading state is toggled off on resolution of the Promise. Closes #431.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the suggestions proposed in #431. The
bhSubmitdirective responsible for toggle the form's $loading state now supports inputs other than Promises. If the input is not a promise, the form immediately cancels the $loading state. Otherwise, the $loading state is toggled off on resolution of the Promise.Closes #431.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!