Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature Request) bhFormDefaults directive #502

Closed
jniles opened this issue Jun 15, 2016 · 0 comments
Closed

(Feature Request) bhFormDefaults directive #502

jniles opened this issue Jun 15, 2016 · 0 comments
Assignees
@jniles
Labels
Feature Request Refactor

Comments

@jniles
Copy link
Contributor

jniles commented Jun 15, 2016 •
edited
Loading

Previously, @lomamech did a lot of good work to ensure our forms behave properly, using autocomplete="off", autocapitalize="off", and so on. In a recent bug repot chrome has stopped respecting the "off" attribute for autocomplete.

There is a fix, which is to change "off" to any other string (like "none" or "false", or "disabled"). Since we will have to change every single form, I propose we create a directive bhFormDefaults that attaches the autocomplete, autocapitalize, etc, attributes to the form element, instead of doing it manually. That way, if the chrome team changes its mind again, we only have to change one file, the bhFormDefaults file.

Like this:

<form name=" SomeForm" bh-form-defaults>

@IMA-WorldHealth/local-contributors what do you think?
@jniles jniles added this to the Future milestone Jun 15, 2016
@jniles jniles self-assigned this Jun 28, 2016
jniles referenced this issue in jniles/bhima Jun 28, 2016
feat(bhFormDefaults): form defaults automatically
13bea28 
This commit adds a new directive `bhFormDefaults` to automatically add
attributes to any form element.  These attributes are:
 1. `autocomplete`
 2. `autocapitalize`
 3. `autocorrect`

The directive turns them off by setting them to "none".  If a browser
updates in the future to ignore the "none" directive, they can easily be
updated.

Closes #502.
@jniles jniles mentioned this issue Jun 28, 2016
Merged
4 tasks
jniles referenced this issue in jniles/bhima Jun 28, 2016
feat(bhFormDefaults): form defaults automatically
a52c610 
This commit adds a new directive `bhFormDefaults` to automatically add
attributes to any form element.  These attributes are:
 1. `autocomplete`
 2. `autocapitalize`
 3. `autocorrect`

The directive turns them off by setting them to "none".  If a browser
updates in the future to ignore the "none" directive, they can easily be
updated.

Closes #502.
sfount pushed a commit that referenced this issue Jun 28, 2016
@jniles @sfount
feat(bhFormDefaults): form defaults automatically (#542)
7441018 
This commit adds a new directive `bhFormDefaults` to automatically add
attributes to any form element.  These attributes are:
 1. `autocomplete`
 2. `autocapitalize`
 3. `autocorrect`

The directive turns them off by setting them to "none".  If a browser
updates in the future to ignore the "none" directive, they can easily be
updated.

Closes #502.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Feature Request Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles