fix(filters): ensure that filter clear is visible #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the bhFilterBar never covers the "clear all filters" button to ensure that the end to end test never fail and the user is always able to click the button. Unfortunately, this also makes it so that `flex-content` overflows vertically on the grid, which is not the best user experience. We should investigate this CSS issue soon to make sure that the UX is still preserved.
|
This fix LGTM - @jniles can you make an issue with the required CSS fix? This will be merged as soon as tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the bhFilterBar never covers the "clear all filters" button to ensure that the end to end test never fail and the user is always able to click the button.
Unfortunately, this also makes it so that
flex-contentoverflows vertically on the grid, which is not the best user experience. We should investigate this CSS issue soon to make sure that the UX is stillpreserved.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!