Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the Voucher Registry #671

Closed
jniles opened this issue Aug 26, 2016 · 2 comments
Closed

Improvements to the Voucher Registry #671

jniles opened this issue Aug 26, 2016 · 2 comments
Assignees
@jniles
Labels
Feature Request Refactor

Comments

@jniles
Copy link
Contributor

jniles commented Aug 26, 2016

This issue tracks improvements to the Voucher Registry (#/vouchers).

  1. The Voucher Registry should open the groups by default.
  2. The filtering could be far more powerful:
    1. We should support filtering on the following fields:
      1. user_id
      2. voucher_type
      3. date
      4. reference
      5. amount
      6. account
      7. currency_id
      8. entity_uuid
    2. There should be a way to clear filters rather than just filtering again.
    3. Filters should be present on the printed report and change the data of the report.
  3. The amount columns should be rendered as a currency.
  4. The ... action column should have a maximum width.

These improvements should be made before shipping the first version of the module.
@jniles jniles added this to the Finance Implementation milestone Aug 26, 2016
@jniles jniles self-assigned this Dec 23, 2016
@jniles
Copy link
Contributor Author

jniles commented Dec 23, 2016

I'll tackle this one this weekend.

@jniles
Copy link
Contributor Author

jniles commented Feb 6, 2017

Once #1126 is merged, I'll take a look at the filtering on this. The rest are done, I believe.

jniles pushed a commit to jniles/bhima that referenced this issue Feb 15, 2017
fix(vouchers): render the amount as currency
b447076 
This commit ensures that the voucher registry renders the amounts as
currencies.

Partially addresses IMA-WorldHealth#671.
@jniles jniles mentioned this issue Feb 15, 2017
Merged
4 tasks
jniles pushed a commit to jniles/bhima that referenced this issue Feb 15, 2017
fix(vouchers): render the amount as currency
77bda5d 
This commit ensures that the voucher registry renders the amounts as
currencies.

Partially addresses IMA-WorldHealth#671.
jniles pushed a commit that referenced this issue Feb 15, 2017
@jniles
fix(vouchers): render the amount as currency
213eb97 
This commit ensures that the voucher registry renders the amounts as
currencies.

Partially addresses #671.
jniles pushed a commit to jniles/bhima that referenced this issue Mar 1, 2017
feat(vouchers): implement voucher search modal
ab7f5f3 
This commit implements the voucher search modal.  The following fields
are searchable:
 1. Date (range)
 2. Reference
 3. Description
 4. User

Closes IMA-WorldHealth#671.
@jniles jniles mentioned this issue Mar 1, 2017
Merged
4 tasks
sfount pushed a commit that referenced this issue Mar 2, 2017
@sfount
feat(vouchers): implement voucher search modal
235ec8d 
This commit implements the voucher search modal.  The following fields
are searchable:
 1. Date (range)
 2. Reference
 3. Description
 4. User

Closes #671.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Feature Request Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles