Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Transition Cash API to no longer require amounts in cash items #683

Closed
jniles opened this issue Sep 6, 2016 · 0 comments
Closed

(refactor) Transition Cash API to no longer require amounts in cash items #683

jniles opened this issue Sep 6, 2016 · 0 comments
Assignees
@jniles
Labels
Refactor

Comments

@jniles
Copy link
Collaborator

jniles commented Sep 6, 2016

The current cash payments API takes in an invoice_uuid and an amount for each invoice, as well as the global amount for the cash payment. Since allocation is done once on the server during the WriteCashItems procedure, I propose that we remove the amount field sent to the server with each cash item. Instead, the amount will be calculated from the global payment amount in the WriteCashItems() procedure. That way, we will not have to maintain extra client code for calculating allocations that are never used.
@jniles jniles added the Refactor label Sep 6, 2016
@jniles jniles added this to the Finance Implementation milestone Sep 6, 2016
@jniles jniles self-assigned this Sep 6, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Sep 6, 2016
fix(cash): update cash client w/ new db
981402b 
This commit updates the cash client to follow the new server/db
procedures that were introduced in IMA-WorldHealth#678.  In particular, the cash is no
longer exchanged into the enterprise currency on the client.  It also
removes the allocation of the cash values from the client.

Closes IMA-WorldHealth#683.
jniles pushed a commit to jniles/bhima that referenced this issue Sep 6, 2016
fix(cash): update cash client w/ new db
8420269 
This commit updates the cash client to follow the new server/db
procedures that were introduced in IMA-WorldHealth#678.  In particular, the cash is no
longer exchanged into the enterprise currency on the client.  It also
removes the allocation of the cash values from the client.

Closes IMA-WorldHealth#683.
jniles pushed a commit to jniles/bhima that referenced this issue Sep 7, 2016
fix(cash): update cash client w/ new db
a939db3 
This commit updates the cash client to follow the new server/db
procedures that were introduced in IMA-WorldHealth#678.  In particular, the cash is no
longer exchanged into the enterprise currency on the client.  It also
removes the allocation of the cash values from the client.

Closes IMA-WorldHealth#683.
@jniles jniles closed this as completed in 6b5c891 Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles