Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a filter for a telephone number #77

Closed
jniles opened this issue Feb 4, 2016 · 2 comments
Closed

Implement a filter for a telephone number #77

jniles opened this issue Feb 4, 2016 · 2 comments
Assignees

Comments

@jniles
Copy link
Contributor

jniles commented Feb 4, 2016

There are a few places we need to display telephone numbers in the application (receipts, reports, lists of users, etc). A handy component to have would be a telephone filter. Something that could be easily embedded in a view such as this:

<span>{{ patient.telephone | telephone }}</span>

... to yield a nicely formatted telephone number (e.g. +243 821 453 233).

@DedrickEnc
Copy link
Contributor

How the system will know about the code, we will deal with locale.js (_locale.js is the right name ?_)? because each country has is own code for telephone number.

@jniles
Copy link
Contributor Author

jniles commented Feb 8, 2016

This filter would only use information provided by the user. So, if the user writes "0821238945", it would render 082 123 8945, instead of trying to guess the country code.

... if we wanted to get all the information possible, on the telephone <input type="telephone"> we might put a drop down for every country code, preloaded into the application. But I think it is too much work for little benefit at the moment. It's a good idea though! Maybe we can plan it as a long-term feature to add polish.

@jniles jniles self-assigned this Feb 21, 2016
jniles referenced this issue in jniles/bhima Feb 21, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 21, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 22, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 22, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 24, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 24, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 24, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 25, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 25, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 27, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Feb 29, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Mar 2, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Mar 2, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Mar 3, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
jniles referenced this issue in jniles/bhima Mar 4, 2016
This commit implements a telephone number filter in Angular to allow
pretty display of telephone numbers.  For example usage, check out the
cash module receipt.

Closes #77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants