Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORE(lib): deprecate util, validate, sanitize #84

Merged
merged 1 commit into from
Feb 11, 2016
Merged

CHORE(lib): deprecate util, validate, sanitize #84

merged 1 commit into from
Feb 11, 2016

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Feb 5, 2016

This commit deprecates and deletes the vast majority of code in the
following files:

  • lib/util.js
  • lib/validate.js
  • lib/sanitize.js

Any remaining methods have been wrapped in NodeJS's util.deprecate()
method to indicate that they should not be used. These methods will be
completely removed in the coming month.

Additionally, lodash has been added as a dependency. This serves to
fill some of the needs left by the deletion and deprecation of our lib
functions.

Closes #32.

@sfount
Copy link
Contributor

sfount commented Feb 7, 2016

The movement to a better tested, more commonly known utility library seems like a good move. This is a very thought out deprication procedure. I will merge this as soon as the conflict with or package json is resolved (if not done I can do this merge on Monday).

@jniles
Copy link
Collaborator Author

jniles commented Feb 8, 2016

@sfount, rebase to master complete. When Travis is green, it should be mergable.

@jniles jniles force-pushed the chore-replace-lib branch 2 times, most recently from 4c81c0d to ad52496 Compare February 9, 2016 14:28
@jniles
CHORE(lib): deprecate util, validate, sanitize
3f23814 
This commit deprecates and deletes the vast majority of code in the
following files:
 - lib/util.js
 - lib/validate.js
 - lib/sanitize.js

Any remaining methods have been wrapped in NodeJS's util.deprecate()
method to indicate that they should not be used.  These methods will be
completely removed in the coming month.

Additionally, lodash has been added as a dependency.  This serves to
fill some of the needs left by the deletion and deprecation of our lib
functions.

Closes #32.
@jniles
Copy link
Collaborator Author

jniles commented Feb 11, 2016

@sfount, could I get a review this morning?

sfount added a commit that referenced this pull request Feb 11, 2016
@sfount
Merge pull request #84 from jniles/chore-replace-lib
2d3621b 
CHORE(lib): deprecate util, validate, sanitize
@sfount sfount merged commit 2d3621b into IMA-WorldHealth:master Feb 11, 2016
@jniles jniles deleted the chore-replace-lib branch February 11, 2016 11:07
jniles referenced this pull request in jniles/bhima Jan 6, 2017
fix(cash): invoices use new references
42e3ce7 
This commit modifies the server to return new references on the debtor's
previous unbalanced invoices route.  They are correct to use
IV.{project_id}.{reference}.

Closes #84.
jniles referenced this pull request in jniles/bhima Jan 7, 2017
@jniles
fix(cash): invoices use new references
39bb976 
This commit modifies the server to return new references on the debtor's
previous unbalanced invoices route.  They are correct to use
IV.{project_id}.{reference}.

Closes #84.
bors bot added a commit that referenced this pull request Jan 12, 2018
@bors
Merge #2447
0a8f305 
2447: Update chai-spies to the latest version 🚀 r=jniles a=greenkeeper[bot]


## Version **1.0.0** of [chai-spies](https://github.com/chaijs/chai-spies) was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      chai-spies
    </td>
  </tr>
  <tr>
    <th align=left>
      Current Version
    </td>
    <td>
      0.7.1
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      dependency
    </td>
  </tr>
</table>

The version **1.0.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of chai-spies.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Commits</summary>
<p>The new version differs by 44 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/1f79da565cb6bb0d05968341179e5af3be786e28"><code>1f79da5</code></a> <code>chore(package): update rollup to version 0.53.4</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/ededa6af6786b9df2fdf5dbdb85dc921394e71e1"><code>ededa6a</code></a> <code>Merge pull request #93 from stalniy/feat/fn-body</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/9b599ca4b948a869dbf9397aeda63c609f21eaad"><code>9b599ca</code></a> <code>feat(spy): adds original function body to be exposed in spy.toString()</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/9a2d248098a2dfd7e804cc3691f8d8ad786b6116"><code>9a2d248</code></a> <code>docs(README): adds documentation about sandboxes and new methods</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/55ad5a5eca809015bddf69b9793125133b618adb"><code>55ad5a5</code></a> <code>1.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/509926a72174b178f0d78182a7b7a4463068550d"><code>509926a</code></a> <code>Merge pull request #91 from stalniy/fix/updates</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/27d9769faced90475edd22bf997cd3c1a71f53b9"><code>27d9769</code></a> <code>Fix formatting if readme</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/fc83ab53395c987c4d8729b895846d72835b9f83"><code>fc83ab5</code></a> <code>chore(travis): updates list of testing node versions</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/19dfebca47f0257e3095cf79249f01f230cf8ecb"><code>19dfebc</code></a> <code>chore(deps): upgrades rollup</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/c27ab283d2ecb7b74141aa62c1b4d20f9991a603"><code>c27ab28</code></a> <code>chore(package): drop support for node 0.x</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/f8c4df7d553e5e8c57a9c0ce0296b4052b00077f"><code>f8c4df7</code></a> <code>Merge pull request #84 from damianb/patch-2</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/fe7ed2a5cdef162bb97c180a92d731aa57c75a3a"><code>fe7ed2a</code></a> <code>Remove link to very dead project</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/fa6a9b05848952859134743e9ee6dd4f07c73f38"><code>fa6a9b0</code></a> <code>Merge pull request #80 from mLuby/patch-1</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/dab43739a19feb38be8ca5d9801d38cf6bc93b68"><code>dab4373</code></a> <code>Update Chai URL in README</code></li>
<li><a href="https://urls.greenkeeper.io/chaijs/chai-spies/commit/e7530f11dbd4b4bdf4ef8d52d41ac2d2f429b9e9"><code>e7530f1</code></a> <code>Merge pull request #63 from chaijs/remove-lgtm</code></li>
</ul>
<p>There are 44 commits in total.</p>
<p>See the <a href="https://urls.greenkeeper.io/chaijs/chai-spies/compare/9309677747faae40badb5219d1ef41d039273a60...1f79da565cb6bb0d05968341179e5af3be786e28">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>


---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jniles @sfount